Skip to content

bugfix revm set_storage gas cost #9823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xRVE merged 7 commits into from
Sep 25, 2025
Merged

bugfix revm set_storage gas cost #9823

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
472aeee
bugfix revm set_storage gas cost
Sep 24, 2025
7476ae8
added sload_error_reading_non_32_byte_value in host.rs
Sep 24, 2025
b2a1d81
added assert for 33 bytes in sload_error_reading_non_32_byte_value
Sep 24, 2025
eebff13
comments
Sep 24, 2025
2385c2d
log in tload
Sep 24, 2025
a1396fc
Update from github-actions[bot] running command 'prdoc --audience run…
github-actions[bot] Sep 24, 2025
ac1f665
Update substrate/frame/revive/src/vm/evm/instructions/host.rs
0xRVE Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions substrate/frame/revive/src/vm/evm/instructions/host.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,10 @@ fn store_helper<'ext, E: Ext>(
///
/// Stores a word to storage.
pub fn sstore<'ext, E: Ext>(context: Context<'_, 'ext, E>) {
let old_bytes = context.interpreter.extend.max_value_size();
Comment thread
pgherveou marked this conversation as resolved.
store_helper(
context,
RuntimeCosts::SetStorage { new_bytes: 32, old_bytes: 0 },
RuntimeCosts::SetStorage { new_bytes: 32, old_bytes },
|ext, key, value, take_old| ext.set_storage(key, value, take_old),
|new_bytes, old_bytes| RuntimeCosts::SetStorage { new_bytes, old_bytes },
);
Expand All @@ -180,9 +181,10 @@ pub fn sstore<'ext, E: Ext>(context: Context<'_, 'ext, E>) {
/// EIP-1153: Transient storage opcodes
/// Store value to transient storage
pub fn tstore<'ext, E: Ext>(context: Context<'_, 'ext, E>) {
let old_bytes = context.interpreter.extend.max_value_size();
Comment thread
pgherveou marked this conversation as resolved.
store_helper(
context,
RuntimeCosts::SetTransientStorage { new_bytes: 32, old_bytes: 0 },
RuntimeCosts::SetTransientStorage { new_bytes: 32, old_bytes },
|ext, key, value, take_old| ext.set_transient_storage(key, value, take_old),
|new_bytes, old_bytes| RuntimeCosts::SetTransientStorage { new_bytes, old_bytes },
);
Expand Down
Loading