pallet-assets: extract precompiles to a separate crate

Cargo.toml

@@ -943,7 +943,7 @@ pallet-asset-conversion-tx-payment = { path = "substrate/frame/transaction-payme
 pallet-asset-rate = { path = "substrate/frame/asset-rate", default-features = false }
 pallet-asset-rewards = { path = "substrate/frame/asset-rewards", default-features = false }
 pallet-asset-tx-payment = { path = "substrate/frame/transaction-payment/asset-tx-payment", default-features = false }
-pallet-assets = { path = "substrate/frame/assets", default-features = false }
+pallet-assets = { path = "substrate/frame/assets", default-features = false, features = ["precompiles"] }
 pallet-assets-freezer = { path = "substrate/frame/assets-freezer", default-features = false }
 pallet-assets-holder = { path = "substrate/frame/assets-holder", default-features = false }
 pallet-atomic-swap = { default-features = false, path = "substrate/frame/atomic-swap" }

prdoc/pr_9796.prdoc

@@ -0,0 +1,11 @@
+title: "pallet-assets: gate precompiles behind feature flag"
+
+doc:
+  - audience: Runtime Dev
+    description: |
+        Assets pallet includes pallet-revive precompiles and subsequently pull a lot of EVM related dependencies by default. This change
+        hides the precompiles behind a feature flag `precompiles`, so downstream users can opt-in to the precompiles if they need them.
+
+crates:
+  - name: pallet-assets
+    bump: minor

substrate/frame/assets/Cargo.toml

@@ -17,7 +17,7 @@ targets = ["x86_64-unknown-linux-gnu"]
 
 [dependencies]
 codec = { workspace = true }
-ethereum-standards = { workspace = true }
+ethereum-standards = { workspace = true, optional = true }
 impl-trait-for-tuples = { workspace = true }
 log = { workspace = true }
 scale-info = { features = ["derive"], workspace = true }
@@ -28,7 +28,7 @@ frame-support = { workspace = true }
 # `system` module provides us with all sorts of useful stuff and macros depend on it being around.
 frame-benchmarking = { optional = true, workspace = true }
 frame-system = { workspace = true }
-pallet-revive = { workspace = true }
+pallet-revive = { workspace = true, optional = true }
 sp-core = { workspace = true }
 
 [dev-dependencies]
@@ -44,7 +44,7 @@ std = [
 	"frame-system/std",
 	"log/std",
 	"pallet-balances/std",
-	"pallet-revive/std",
+	"pallet-revive?/std",
 	"scale-info/std",
 	"sp-core/std",
 	"sp-io/std",
@@ -55,13 +55,17 @@ runtime-benchmarks = [
 	"frame-support/runtime-benchmarks",
 	"frame-system/runtime-benchmarks",
 	"pallet-balances/runtime-benchmarks",
-	"pallet-revive/runtime-benchmarks",
+	"pallet-revive",
 	"sp-runtime/runtime-benchmarks",
 ]
 try-runtime = [
 	"frame-support/try-runtime",
 	"frame-system/try-runtime",
 	"pallet-balances/try-runtime",
-	"pallet-revive/try-runtime",
+	"pallet-revive?/try-runtime",
 	"sp-runtime/try-runtime",
 ]
+precompiles = [
+    "pallet-revive",
+    "ethereum-standards"
+]

substrate/frame/assets/src/lib.rs

@@ -155,6 +155,7 @@ pub mod benchmarking;
 pub mod migration;
 #[cfg(test)]
 pub mod mock;
+#[cfg(feature = "precompiles")]
 pub mod precompiles;
 #[cfg(test)]
 mod tests;
@@ -1204,7 +1205,7 @@ pub mod pallet {
 				ensure!(details.status == AssetStatus::Live, Error::<T, I>::AssetNotLive);
 				ensure!(origin == details.owner, Error::<T, I>::NoPermission);
 				if details.owner == owner {
-					return Ok(())
+					return Ok(());
 				}
 
 				let metadata_deposit = Metadata::<T, I>::get(&id).deposit;

substrate/frame/assets/src/mock.rs

@@ -20,6 +20,7 @@
 use super::*;
 use crate as pallet_assets;
 
+#[cfg(feature = "precompiles")]
 use crate::precompiles::{InlineIdConfig, ERC20};
 use codec::Encode;
 use frame_support::{
@@ -31,6 +32,16 @@ use sp_runtime::BuildStorage;
 
 type Block = frame_system::mocking::MockBlock<Test>;
 
+#[cfg(not(feature = "precompiles"))]
+construct_runtime!(
+	pub enum Test
+	{
+		System: frame_system,
+		Balances: pallet_balances,
+		Assets: pallet_assets,
+	}
+);
+#[cfg(feature = "precompiles")]
 construct_runtime!(
 	pub enum Test
 	{
@@ -56,6 +67,7 @@ impl pallet_balances::Config for Test {
 	type AccountStore = System;
 }
 
+#[cfg(feature = "precompiles")]
 #[derive_impl(pallet_revive::config_preludes::TestDefaultConfig)]
 impl pallet_revive::Config for Test {
 	type AddressMapper = pallet_revive::TestAccountMapper<Self>;