Skip to content

Deprecate OnRuntimeUpgrade parameter in frame_executive::Executive#9638

Merged
bkchr merged 20 commits intoparitytech:masterfrom
moonbeam-foundation:rq/deprecate-single-block-migrations-from-executive
Sep 12, 2025
Merged

Deprecate OnRuntimeUpgrade parameter in frame_executive::Executive#9638
bkchr merged 20 commits intoparitytech:masterfrom
moonbeam-foundation:rq/deprecate-single-block-migrations-from-executive

Conversation

@RomarQ
Copy link
Copy Markdown
Contributor

@RomarQ RomarQ commented Sep 3, 2025

Follow-up of #9451

Based on PR #1781 and PRDoc, the new way for providing the single block migrations should be through SingleBlockMigrations in frame_system::Config. Providing them from frame_executive::Executive is still supported, but is deprecated.

SingleBlockMigrations this is the new way of configuring migrations that run in a single block. Previously they were defined as last generic argument of Executive. This shift is brings all central configuration about migrations closer into view of the developer (migrations that are configured in Executive will still work for now but is deprecated).

Executive docs will look like:

image

Companion PR in polkadot-fellows/runtimes#844

@RomarQ RomarQ requested a review from a team as a code owner September 3, 2025 15:56
@RomarQ RomarQ changed the title deprecate OnRuntimeUpgrade parameter in Executive struct deprecate OnRuntimeUpgrade parameter in frame_executive::Executive struct Sep 3, 2025
@RomarQ RomarQ changed the title deprecate OnRuntimeUpgrade parameter in frame_executive::Executive struct Deprecate OnRuntimeUpgrade parameter in frame_executive::Executive Sep 3, 2025
@RomarQ RomarQ marked this pull request as draft September 3, 2025 16:19
@RomarQ RomarQ marked this pull request as ready for review September 3, 2025 18:43
@bkchr bkchr added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Sep 5, 2025
@bkchr bkchr requested a review from ggwpez September 5, 2025 00:10
@RomarQ
Copy link
Copy Markdown
Contributor Author

RomarQ commented Sep 8, 2025

@ggwpez Can you have a look?

Copy link
Copy Markdown
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@bkchr bkchr added this pull request to the merge queue Sep 11, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 11, 2025
@RomarQ
Copy link
Copy Markdown
Contributor Author

RomarQ commented Sep 11, 2025

@bkchr fixed the check-semver job. The merge should work now.

@bkchr bkchr enabled auto-merge September 11, 2025 21:03
@bkchr bkchr added this pull request to the merge queue Sep 12, 2025
auto-merge was automatically disabled September 12, 2025 09:52

Pull Request is not mergeable

Merged via the queue into paritytech:master with commit 6c06057 Sep 12, 2025
292 of 300 checks passed
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
#9638)

Follow-up of #9451

Based on PR #1781 and
[PRDoc](https://github.com/paritytech/polkadot-sdk/blob/beb9030b249cc078b3955232074a8495e7e0302a/prdoc/1.9.0/pr_1781.prdoc#L29),
the new way for providing the single block migrations should be through
`SingleBlockMigrations` in `frame_system::Config`. Providing them from
`frame_executive::Executive` is still supported, but is deprecated.

> `SingleBlockMigrations` this is the new way of configuring migrations
that run in a single block. Previously they were defined as last generic
argument of Executive. This shift is brings all central configuration
about migrations closer into view of the developer (migrations that are
configured in Executive will still work for now but is deprecated).

`Executive` docs will look like:

<img width="800" alt="image"
src="https://github.com/user-attachments/assets/6f285c26-5c61-4350-a41b-aebc6b856601"
/>

Companion PR in polkadot-fellows/runtimes#844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T1-FRAME This PR/Issue is related to core FRAME, the framework.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants