Improve inbound_queue::BenchmarkHelper to add more flexibility#9627
Merged
bkontur merged 21 commits intoSep 22, 2025
Merged
Conversation
Contributor
Author
|
@claravanstaden maybe you could take a look here 🙌 |
bkontur
reviewed
Sep 3, 2025
bkontur
approved these changes
Sep 3, 2025
Contributor
Author
|
@bkontur just checking — do I need more reviews before merging this? |
tmpolaczyk
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Sep 17, 2025
tmpolaczyk
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Sep 18, 2025
bkchr
approved these changes
Sep 18, 2025
Member
|
@dimartiro tests are still failing that first need to be fixed. |
dimartiro
force-pushed
the
improve-inbound-queue-benchmarks-helper
branch
from
e25d268 to
0da9001
Compare
dimartiro
force-pushed
the
improve-inbound-queue-benchmarks-helper
branch
from
1d4c834 to
9e6dc19
Compare
dimartiro
force-pushed
the
improve-inbound-queue-benchmarks-helper
branch
from
9e6dc19 to
02a433f
Compare
Contributor
|
/cmd prdoc --audience runtime_dev --bump patch |
bkontur
added
the
T12-benchmarks
…time_dev --bump patch'
bkontur
reviewed
Sep 22, 2025
claravanstaden
approved these changes
Sep 22, 2025
Contributor
Author
Thanks Basti. I think I’ve addressed everything, let me know if there is something else missing |
Merged
via the queue into
paritytech:master
with commit Sep 22, 2025
ef10d5e
245 of 248 checks passed
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
# Description Improve the usage of the `inbound_queue::BenchmarkHelper` to decouple the mocks from the benchmark. This change will enable any user to benchmark custom messages since now it's harcoded to the register_token_message only --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve the usage of the
inbound_queue::BenchmarkHelperto decouple the mocks from the benchmark.This change will enable any user to benchmark custom messages since now it's harcoded to the register_token_message only