Skip to content

[unstable2507] Backport #9451#9624

Merged
bkchr merged 1 commit intounstable2507from
backport-9451-to-unstable2507
Sep 4, 2025
Merged

[unstable2507] Backport #9451#9624
bkchr merged 1 commit intounstable2507from
backport-9451-to-unstable2507

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

Backport #9451 into unstable2507 from RomarQ.

See the documentation on how to use this bot.

…e_upgrade (#9451)

Recently, when moving the single block migrations from
`frame_executive::Executive` to `SingleBlockMigrations` in
`frame_system::Config`, I noticed that `try_runtime_upgrade` was
ignoring the `SingleBlockMigrations` defined in frame_system. More
context at polkadot-fellows/runtimes#844

Based on PR #1781 and
[PRDoc](https://github.com/paritytech/polkadot-sdk/blob/beb9030b249cc078b3955232074a8495e7e0302a/prdoc/1.9.0/pr_1781.prdoc#L29),
the new way for providing the single block migrations should be through
`SingleBlockMigrations` in `frame_system::Config`. Providing them from
`frame_executive::Executive` is still supported, but from what I
understood is or will be deprecated.

> `SingleBlockMigrations` this is the new way of configuring migrations
that run in a single block. Previously they were defined as last generic
argument of Executive. This shift is brings all central configuration
about migrations closer into view of the developer (migrations that are
configured in Executive will still work for now but is deprecated).

## Follow-up Changes
Will try to open a pull request tomorrow for deprecating the use of
`OnRuntimeUpgrade` in `frame_executive::Executive`.

(cherry picked from commit 7753112)
@paritytech-release-backport-bot paritytech-release-backport-bot Bot requested a review from a team as a code owner September 2, 2025 11:25
@github-actions github-actions Bot added the A3-backport Pull request is already reviewed well in another branch. label Sep 2, 2025
@RomarQ
Copy link
Copy Markdown
Contributor

RomarQ commented Sep 4, 2025

Do I need to do anything on this branch?

@bkchr bkchr merged commit be11e38 into unstable2507 Sep 4, 2025
261 of 288 checks passed
@bkchr bkchr deleted the backport-9451-to-unstable2507 branch September 4, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants