Skip to content

[stable2506] Backport #9451#9623

Merged
EgorPopelyaev merged 1 commit intostable2506from
backport-9451-to-stable2506
Sep 2, 2025
Merged

[stable2506] Backport #9451#9623
EgorPopelyaev merged 1 commit intostable2506from
backport-9451-to-stable2506

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

Backport #9451 into stable2506 from RomarQ.

See the documentation on how to use this bot.

…e_upgrade (#9451)

Recently, when moving the single block migrations from
`frame_executive::Executive` to `SingleBlockMigrations` in
`frame_system::Config`, I noticed that `try_runtime_upgrade` was
ignoring the `SingleBlockMigrations` defined in frame_system. More
context at polkadot-fellows/runtimes#844

Based on PR #1781 and
[PRDoc](https://github.com/paritytech/polkadot-sdk/blob/beb9030b249cc078b3955232074a8495e7e0302a/prdoc/1.9.0/pr_1781.prdoc#L29),
the new way for providing the single block migrations should be through
`SingleBlockMigrations` in `frame_system::Config`. Providing them from
`frame_executive::Executive` is still supported, but from what I
understood is or will be deprecated.

> `SingleBlockMigrations` this is the new way of configuring migrations
that run in a single block. Previously they were defined as last generic
argument of Executive. This shift is brings all central configuration
about migrations closer into view of the developer (migrations that are
configured in Executive will still work for now but is deprecated).

## Follow-up Changes
Will try to open a pull request tomorrow for deprecating the use of
`OnRuntimeUpgrade` in `frame_executive::Executive`.

(cherry picked from commit 7753112)
@paritytech-release-backport-bot paritytech-release-backport-bot Bot requested a review from a team as a code owner September 2, 2025 11:25
@github-actions github-actions Bot added the A3-backport Pull request is already reviewed well in another branch. label Sep 2, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 2, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev enabled auto-merge (squash) September 2, 2025 12:06
@EgorPopelyaev EgorPopelyaev merged commit 03d0b02 into stable2506 Sep 2, 2025
273 of 280 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-9451-to-stable2506 branch September 2, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants