[unstable2507] Backport #9201#9542
Closed
paritytech-release-backport-bot[bot] wants to merge 4 commits intounstable2507from
Closed
[unstable2507] Backport #9201#9542paritytech-release-backport-bot[bot] wants to merge 4 commits intounstable2507from
paritytech-release-backport-bot[bot] wants to merge 4 commits intounstable2507from
Conversation
…#9201) # Description - log::info! the error of accessing `GetParachainInfo::parachain_id()` runtime api if any, before reading the `para_id` from the chain specification (relevant for debugging). - removes comments/deprecation notices throughout the code that introduce `para-id` flag removal (from chain-spec-builder and support for parsing it from chain specifications) Closes #9217 ## Integration N/A ## Review Notes N/A --------- Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sebastian Kunert <mail@skunert.dev> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> (cherry picked from commit 2660bf5)
iulianbarbu
approved these changes
Aug 22, 2025
Contributor
|
Check publish compile fails here. The error looks different from the previous errors of the PRs against master. This seems to have been the case for other backports that were merged in unstable2507 before. Is this a known issue, or it should be investigated/fixed? |
Contributor
|
Seems like latest backport PR merged in unstabe2507 suffered from same fate: https://github.com/paritytech/polkadot-sdk/actions/runs/17725056530/job/50364276349. @EgorPopelyaev any idea why? Probably this will impact the crates releasing based on this branch, but maybe you know better if this failure is really an issue. LMK, otherwise we can merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #9201 into
unstable2507from iulianbarbu.See the documentation on how to use this bot.