Skip to content

[XCMP] take_first_concatenated_xcm() improvements#9539

Merged
serban300 merged 8 commits intoparitytech:masterfrom
serban300:take-first-concatenated-xcm-improvements
Aug 25, 2025
Merged

[XCMP] take_first_concatenated_xcm() improvements#9539
serban300 merged 8 commits intoparitytech:masterfrom
serban300:take-first-concatenated-xcm-improvements

Conversation

@serban300
Copy link
Contributor

@serban300 serban300 commented Aug 22, 2025 •
edited
Loading

This PR:

  • improves take_first_concatenated_xcm() avoiding the XCM re-encoding
  • makes the benchmarks for take_first_concatenated_xcm() more granular, accounting for the number of bytes of the message

@serban300 serban300 self-assigned this Aug 22, 2025
@serban300 serban300 requested a review from a team as a code owner August 22, 2025 07:12
@serban300 serban300 added I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T1-FRAME This PR/Issue is related to core FRAME, the framework. labels Aug 22, 2025
@serban300
Copy link
Contributor Author

serban300 commented Aug 22, 2025

/cmd bench --pallet cumulus_pallet_xcmp_queue

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

Command "bench --pallet cumulus_pallet_xcmp_queue" has started 🚀 See logs here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

Command "bench --pallet cumulus_pallet_xcmp_queue" has finished ✅ See logs here

Details

Subweight results:

Please check subweight.log for the full output

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- asset-hub-westend: ['cumulus_pallet_xcmp_queue']
-- asset-hub-rococo: ['cumulus_pallet_xcmp_queue']
-- bridge-hub-rococo: ['cumulus_pallet_xcmp_queue']
-- bridge-hub-westend: ['cumulus_pallet_xcmp_queue']
-- collectives-westend: ['cumulus_pallet_xcmp_queue']
-- coretime-rococo: ['cumulus_pallet_xcmp_queue']
-- coretime-westend: ['cumulus_pallet_xcmp_queue']
-- people-rococo: ['cumulus_pallet_xcmp_queue']
-- people-westend: ['cumulus_pallet_xcmp_queue']

@serban300 serban300 changed the title [WIP] [XCMP] take_first_concatenated_xcm() improvements [XCMP] take_first_concatenated_xcm() improvements Aug 22, 2025
@serban300
Copy link
Contributor Author

serban300 commented Aug 22, 2025

/cmd prdoc --audience runtime_dev --bump patch

@serban300 serban300 force-pushed the take-first-concatenated-xcm-improvements branch from b8dacd4 to 3ae30c7 Compare August 22, 2025 10:33
@serban300 serban300 requested a review from ggwpez August 22, 2025 11:24
ggwpez
ggwpez reviewed Aug 22, 2025
View reviewed changes
ggwpez
ggwpez reviewed Aug 22, 2025
View reviewed changes
ggwpez
ggwpez reviewed Aug 22, 2025
View reviewed changes
@serban300
Copy link
Contributor Author

serban300 commented Aug 22, 2025

/cmd bench --pallet cumulus_pallet_xcmp_queue

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

Command "bench --pallet cumulus_pallet_xcmp_queue" has started 🚀 See logs here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

Command "bench --pallet cumulus_pallet_xcmp_queue" has finished ✅ See logs here

Details

Subweight results:

Please check subweight.log for the full output

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- asset-hub-westend: ['cumulus_pallet_xcmp_queue']
-- asset-hub-rococo: ['cumulus_pallet_xcmp_queue']
-- bridge-hub-rococo: ['cumulus_pallet_xcmp_queue']
-- bridge-hub-westend: ['cumulus_pallet_xcmp_queue']
-- collectives-westend: ['cumulus_pallet_xcmp_queue']
-- coretime-rococo: ['cumulus_pallet_xcmp_queue']
-- coretime-westend: ['cumulus_pallet_xcmp_queue']
-- people-rococo: ['cumulus_pallet_xcmp_queue']
-- people-westend: ['cumulus_pallet_xcmp_queue']

@serban300 serban300 enabled auto-merge August 25, 2025 07:06
@serban300 serban300 added this pull request to the merge queue Aug 25, 2025
Merged via the queue into paritytech:master with commit 2cb8f12 Aug 25, 2025
328 of 339 checks passed
@serban300 serban300 deleted the take-first-concatenated-xcm-improvements branch August 25, 2025 08:45
@serban300 serban300 mentioned this pull request Aug 25, 2025
Closed
4 tasks
pepoviola pushed a commit that referenced this pull request Aug 26, 2025
@serban300 @github-actions @pepoviola
[XCMP] take_first_concatenated_xcm() improvements (#9539)
f954603 
This PR:
- improves `take_first_concatenated_xcm()` avoiding the XCM re-encoding
- makes the benchmarks for `take_first_concatenated_xcm()` more
granular, accounting for the number of bytes of the message

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
@serban300 @github-actions @alvicsam
[XCMP] take_first_concatenated_xcm() improvements (#9539)
b58dabc 
This PR:
- improves `take_first_concatenated_xcm()` avoiding the XCM re-encoding
- makes the benchmarks for `take_first_concatenated_xcm()` more
granular, accounting for the number of bytes of the message

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@manuelmauro manuelmauro mentioned this pull request Mar 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggwpez ggwpez ggwpez approved these changes

@x3c41a x3c41a x3c41a approved these changes

Assignees

@serban300 serban300

Labels

I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Projects

[preview] release tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serban300 @ggwpez @x3c41a @pgherveou