Skip to content

[stable2506] Backport #9516#9519

Merged
bkontur merged 1 commit into
stable2506from
backport-9516-to-stable2506
Aug 20, 2025
Merged

[stable2506] Backport #9516#9519
bkontur merged 1 commit into
stable2506from
backport-9516-to-stable2506

Conversation

@paritytech-release-backport-bot

Copy link
Copy Markdown

Backport #9516 into stable2506 from bkontur.

See the documentation on how to use this bot.

Discovered by: polkadot-fellows/runtimes#853

It’s likely that this PR:
[https://github.com/paritytech/polkadot-sdk/pull/7720](https://github.com/paritytech/polkadot-sdk/pull/7720)
broke weight generation/compilation. For example, for `promote_fast`,
the weight file is [generated with `u32`—see the screenshot
below](polkadot-fellows/runtimes@3cc49e4#diff-35dfb1113ee202c1375fb2d8982d02a665e5857fec2e0a07b684494c056c8901L190-R194),
which causes compilation errors when `MaxRank = u16`.

<img width="541" height="67" alt="image"
src="https://github.com/user-attachments/assets/03bb3d90-7c09-46c7-8990-21878fc50c61"
/>

## TODO

- [x] find possible fix

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 4c8ccc5)
@paritytech-release-backport-bot paritytech-release-backport-bot Bot requested a review from a team as a code owner August 19, 2025 16:14
@github-actions github-actions Bot added the A3-backport Pull request is already reviewed well in another branch. label Aug 19, 2025
@github-actions github-actions Bot requested a review from bkontur August 19, 2025 16:14
@github-actions

Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@bkontur bkontur merged commit bb71a69 into stable2506 Aug 20, 2025
244 of 246 checks passed
@bkontur bkontur deleted the backport-9516-to-stable2506 branch August 20, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant