Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…nto oty-paseo-fix
ggwpez
added
the
A3-backport
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
| // deposit to reporter + reporter account endowed. | ||
| assert_eq!(System::<T>::read_events_for_pallet::<pallet_balances::Event<T>>().len(), 3); | ||
| // make sure reporter got deposited. | ||
| assert!(System::<T>::read_events_for_pallet::<pallet_balances::Event<T>>() |
There was a problem hiding this comment.
From now on, pledge to not approve any PR that does this "event counting" shenanigans :D
| "depositor must always have MinCreateBond stake in the pool, except for when the \ | ||
| pool is being destroyed and the depositor is the last member", | ||
| ); | ||
| let depositor_has_enough_stake = bonded_pool |
There was a problem hiding this comment.
Is this intended? ensure -> warn is a big downgrade in severity
There was a problem hiding this comment.
This is an artifact of this. #444
The assertion should have been warn from the beginning, as this MinCreateBond can change.
| ))] | ||
| pub fn check_ed_imbalance() -> Result<(), DispatchError> { | ||
| let mut failed: u32 = 0; | ||
| pub fn check_ed_imbalance() -> Result<u32, DispatchError> { |
There was a problem hiding this comment.
ah testing only stuff, should have been pub(crate) to begin with. Good catch, but since it is backporting to unstable, let's ignore it? I will keep it in mind for stable backports
| "depositor must always have MinCreateBond stake in the pool, except for when the \ | ||
| pool is being destroyed and the depositor is the last member", | ||
| ); | ||
| let depositor_has_enough_stake = bonded_pool |
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
10 participants
Need to also check that all things are in master.