[pallet-revive] Re-export account and code info structs#9490
Open
cmichi wants to merge 2 commits intoparitytech:masterfrom
Open
[pallet-revive] Re-export account and code info structs#9490cmichi wants to merge 2 commits intoparitytech:masterfrom
cmichi wants to merge 2 commits intoparitytech:masterfrom
Conversation
Contributor
|
Aren't you using the generated metadata subxt types for these storage in cargo contract? |
Contributor
Author
We are using the metadata, but not for that particular functionality. I'm not sure if amything prevented using it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Are you up for re-exporting these info structs publicly? We query the following storage items in
cargo contract infoand use the result to compile information about an on-chain contract:Making them public would allow us to depend on the re-exports, avoiding having to copy them.
cc @athei @pgherveou