-
Notifications
You must be signed in to change notification settings - Fork 1.2k
polkadot-omni-node: fixes and changes related to GetParachainInfo
#9201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
3b0bc90
507d9a0
c0bc83f
dcb077d
a715b82
18d7acf
ed6758b
0eba8c1
f79eae8
f3a286c
cc19091
22354df
bc8b8f2
8604bc8
09297cb
b41cd14
507b83b
0b2aff5
9d2ccdd
8141807
2ffdafb
1caf869
2e347ca
17b8e3b
b31f3f3
782da88
e01266b
3ebdfeb
c352e00
f92533b
fc3e651
5e572b8
324a32a
f650be3
10c7a31
6d3949c
63d3097
a380e04
165494a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -31,6 +31,11 @@ pub fn asset_hub_westend_development_config() -> GenericChainSpec { | |||||||||||
| .with_id("asset-hub-westend-dev") | ||||||||||||
| .with_chain_type(ChainType::Local) | ||||||||||||
| .with_genesis_config_preset_name(sp_genesis_builder::DEV_RUNTIME_PRESET) | ||||||||||||
| .with_genesis_config_patch(serde_json::json!({ | ||||||||||||
| "parachainInfo": { | ||||||||||||
| "parachainId": 1000u32, | ||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I admit that I forgot if we discussed it before, but is this patch actually necessary? To me it looks like the genesis patch for asset hub westend already contains parachainId 1000: polkadot-sdk/cumulus/parachains/runtimes/assets/asset-hub-westend/src/genesis_config_presets.rs Lines 181 to 185 in 1caf869
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I addressed this, but after an assessment of the need to patch other chain specs, I realized using genesis config isn't needed for asset-hub-rococo and for a few more too. Those functions that patch parachain id with same one from genesis config aren't used in other places, so we can simplify them by removing the para_id parameter. |
||||||||||||
| }, | ||||||||||||
| })) | ||||||||||||
| .with_properties(properties) | ||||||||||||
| .build() | ||||||||||||
| } | ||||||||||||
|
|
@@ -49,6 +54,11 @@ pub fn asset_hub_westend_local_config() -> GenericChainSpec { | |||||||||||
| .with_id("asset-hub-westend-local") | ||||||||||||
| .with_chain_type(ChainType::Local) | ||||||||||||
| .with_genesis_config_preset_name(sp_genesis_builder::LOCAL_TESTNET_RUNTIME_PRESET) | ||||||||||||
| .with_genesis_config_patch(serde_json::json!({ | ||||||||||||
| "parachainInfo": { | ||||||||||||
| "parachainId": 1000u32, | ||||||||||||
| }, | ||||||||||||
| })) | ||||||||||||
| .with_properties(properties) | ||||||||||||
| .build() | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| title: '`polkadot-parachain`: added asset-hub-westend-local paracahinInfo genesis patch' | ||
|
iulianbarbu marked this conversation as resolved.
Outdated
|
||
| doc: | ||
| - audience: [ Runtime Dev, Node Dev, Node Operator ] | ||
|
iulianbarbu marked this conversation as resolved.
Outdated
|
||
| description: |- | ||
| - Provides some updated to the asset-hub-westend-local chain specification, by adding appropriate gensis patch for parachainInfo. | ||
|
iulianbarbu marked this conversation as resolved.
Outdated
|
||
| - refactors the logic related to fetching `para_id` with the node, so that when failing to use `GetParachainInfo::parachain_id` we also get a log with the error (before defaulting to `para_id` extracted from chain spec). | ||
|
iulianbarbu marked this conversation as resolved.
|
||
| crates: | ||
| - name: polkadot-parachain-bin | ||
| bump: minor | ||
| - name: polkadot-omni-node-lib | ||
| bump: minor | ||
Uh oh!
There was an error while loading. Please reload this page.