Skip to content

Fixed westend asset hub ID#9191

Merged
iulianbarbu merged 5 commits intomasterfrom
fix-westend-asset-hub-id
Jul 15, 2025
Merged

Fixed westend asset hub ID#9191
iulianbarbu merged 5 commits intomasterfrom
fix-westend-asset-hub-id

Conversation

@antkve
Copy link
Copy Markdown
Contributor

@antkve antkve commented Jul 14, 2025

Addresses #9190 by adding cumulus_primitives_core::GetParachainInfo impl to the AHW runtime.

@antkve antkve requested review from a team, bkontur and serban300 July 14, 2025 11:05
@antkve antkve added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-no-crate-publish-required The change does not require any crates to be re-published. labels Jul 14, 2025
@karolk91
Copy link
Copy Markdown
Contributor

karolk91 commented Jul 14, 2025

Code looks good but I think you should remove A1-insubstantial and R0-no-crate-publish-required, and create prdoc with minor level change

@antkve
Copy link
Copy Markdown
Contributor Author

antkve commented Jul 14, 2025

Code looks good but I think you should remove A1-insubstantial and R0-no-crate-publish-required, and create prdoc with minor level change

Fair, will do

@serban300 serban300 removed the R0-no-crate-publish-required The change does not require any crates to be re-published. label Jul 14, 2025
@antkve antkve removed the A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Jul 14, 2025
@antkve antkve requested a review from karolk91 July 14, 2025 11:57
karolk91
karolk91 reviewed Jul 14, 2025
View reviewed changes
Comment thread prdoc/pr_9191.prdoc Outdated
@iulianbarbu
Copy link
Copy Markdown
Contributor

iulianbarbu commented Jul 15, 2025

Hey guys, there seem to be some overlap. I opened #9201 because I did not know that this PR is up. Probably we can merge this one and I can rebase/modify PR description for #9201 to account for the other changes I intend to merge.

@antkve can you take care of the labels/semver for the CI, so that we can merge this?

This was referenced Jul 15, 2025
Closed
Merged
@antkve
Copy link
Copy Markdown
Contributor Author

antkve commented Jul 15, 2025

Hey guys, there seem to be some overlap. I opened #9201 because I did not know that this PR is up. Probably we can merge this one and I can rebase/modify PR description for #9201 to account for the other changes I intend to merge.

@antkve can you take care of the labels/semver for the CI, so that we can merge this?

Hi Iulian, sure, will do that shortly.

@antkve @karolk91
Update prdoc/pr_9191.prdoc
b810122 
Co-authored-by: Karol Kokoszka <karol@parity.io>
@iulianbarbu iulianbarbu added the I2-bug The node fails to follow expected behavior. label Jul 15, 2025
@antkve antkve added T14-system_parachains This PR/Issue is related to system parachains. and removed I2-bug The node fails to follow expected behavior. labels Jul 15, 2025
@iulianbarbu iulianbarbu added the T4-runtime_API This PR/Issue is related to runtime APIs. label Jul 15, 2025
@antkve antkve added the I2-bug The node fails to follow expected behavior. label Jul 15, 2025
@antkve antkve enabled auto-merge July 15, 2025 09:11
@antkve antkve added this pull request to the merge queue Jul 15, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 15, 2025
@iulianbarbu iulianbarbu added this pull request to the merge queue Jul 15, 2025
Merged via the queue into master with commit 999b4fa Jul 15, 2025
265 of 332 checks passed
@iulianbarbu iulianbarbu deleted the fix-westend-asset-hub-id branch July 15, 2025 11:22
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
@antkve @karolk91 @alvicsam
Fixed westend asset hub ID (#9191)
a8b429d 
Addresses #9190 by adding cumulus_primitives_core::GetParachainInfo impl
to the AHW runtime.

---------

Co-authored-by: Karol Kokoszka <karol@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pepoviola pepoviola pepoviola approved these changes

@karolk91 karolk91 karolk91 approved these changes

@iulianbarbu iulianbarbu iulianbarbu approved these changes

@serban300 serban300 serban300 approved these changes

@x3c41a x3c41a x3c41a approved these changes

@bkontur bkontur Awaiting requested review from bkontur

+1 more reviewer

@raymondkfcheung raymondkfcheung raymondkfcheung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

I2-bug The node fails to follow expected behavior. T4-runtime_API This PR/Issue is related to runtime APIs. T14-system_parachains This PR/Issue is related to system parachains.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@antkve @karolk91 @iulianbarbu @pepoviola @serban300 @x3c41a @raymondkfcheung @pgherveou