Skip to content

[dnm] net: Improve connectivity to validators by reconnecting on requests #9160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lexnv wants to merge 1 commit into from
Closed

[dnm] net: Improve connectivity to validators by reconnecting on requests #9160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion polkadot/node/network/availability-distribution/src/pov_requester/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ pub async fn fetch_pov<Context>(

ctx.send_message(NetworkBridgeTxMessage::SendRequests(
vec![full_req],
IfDisconnected::ImmediateError,
IfDisconnected::TryConnect,
))
.await;

Expand Down
7 changes: 2 additions & 5 deletions polkadot/node/network/availability-distribution/src/requester/fetch_task/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,11 +358,8 @@ impl RunningTask {

self.sender
.send(FromFetchTask::Message(
NetworkBridgeTxMessage::SendRequests(
vec![requests],
IfDisconnected::ImmediateError,
)
.into(),
NetworkBridgeTxMessage::SendRequests(vec![requests], IfDisconnected::TryConnect)
.into(),
))
.await
.map_err(|_| TaskError::ShuttingDown)?;
Expand Down
2 changes: 1 addition & 1 deletion polkadot/node/network/availability-recovery/src/task/strategy/full.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ impl<Sender: overseer::AvailabilityRecoverySenderTrait> RecoveryStrategy<Sender>
sender
.send_message(NetworkBridgeTxMessage::SendRequests(
vec![Requests::AvailableDataFetchingV1(req)],
IfDisconnected::ImmediateError,
IfDisconnected::TryConnect,
))
.await;

Expand Down
2 changes: 1 addition & 1 deletion polkadot/node/network/collator-protocol/src/validator_side/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ async fn request_collation(
sender
.send_message(NetworkBridgeTxMessage::SendRequests(
vec![requests],
IfDisconnected::ImmediateError,
IfDisconnected::TryConnect,
))
.await;
Ok(())
Expand Down
2 changes: 1 addition & 1 deletion polkadot/node/network/statement-distribution/src/v2/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2920,7 +2920,7 @@ pub(crate) async fn dispatch_requests<Context>(ctx: &mut Context, state: &mut St
// Peer is supposedly connected.
ctx.send_message(NetworkBridgeTxMessage::SendRequests(
vec![Requests::AttestedCandidateV2(request)],
IfDisconnected::ImmediateError,
IfDisconnected::TryConnect,
))
.await;
}
Expand Down
2 changes: 1 addition & 1 deletion ...ate/client/consensus/beefy/src/communication/request_response/outgoing_requests_engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ impl<B: Block, AuthorityId: AuthorityIdBound> OnDemandJustificationsEngine<B, Au
payload,
None,
tx,
IfDisconnected::ImmediateError,
IfDisconnected::TryConnect,
);

self.state = State::AwaitingResponse(peer, req_info, rx);
Expand Down
2 changes: 1 addition & 1 deletion substrate/client/network/src/litep2p/shim/request_response/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ impl RequestResponseProtocol {
request,
tx,
None,
IfDisconnected::ImmediateError,
IfDisconnected::TryConnect,
);

// since remote peer doesn't support the main protocol (`self.protocol`),
Expand Down
2 changes: 1 addition & 1 deletion substrate/client/network/src/request_responses.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,7 +1002,7 @@ impl NetworkBehaviour for RequestResponsesBehaviour {
// We can error if not connected because the
// previous attempt would have tried to establish a
// connection already or errored and we wouldn't have gotten here.
IfDisconnected::ImmediateError,
IfDisconnected::TryConnect,
);
}
}
Expand Down
2 changes: 1 addition & 1 deletion substrate/client/network/sync/src/strategy/chain_sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,7 +899,7 @@ where
self.state_request_protocol_name.clone(),
request.encode_to_vec(),
tx,
IfDisconnected::ImmediateError,
IfDisconnected::TryConnect,
);

SyncingAction::StartRequest {
Expand Down
2 changes: 1 addition & 1 deletion substrate/client/network/sync/src/strategy/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ impl<B: BlockT> StateStrategy<B> {
self.protocol_name.clone(),
request.encode_to_vec(),
tx,
IfDisconnected::ImmediateError,
IfDisconnected::TryConnect,
);

SyncingAction::StartRequest {
Expand Down
2 changes: 1 addition & 1 deletion substrate/client/network/sync/src/strategy/warp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ where
protocol_name,
request.encode(),
tx,
IfDisconnected::ImmediateError,
IfDisconnected::TryConnect,
);

SyncingAction::StartRequest {
Expand Down
Loading