Skip to content

[stable2412] Backport #8839#9070

Closed
paritytech-release-backport-bot[bot] wants to merge 1 commit intostable2412from
backport-8839-to-stable2412
Closed

[stable2412] Backport #8839#9070
paritytech-release-backport-bot[bot] wants to merge 1 commit intostable2412from
backport-8839-to-stable2412

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

Backport #8839 into stable2412 from Sajjon.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Copy Markdown
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-8839-to-stable2412
git worktree add --checkout .worktree/backport-8839-to-stable2412 backport-8839-to-stable2412
cd .worktree/backport-8839-to-stable2412
git reset --hard HEAD^
git cherry-pick -x ee6d22b94d9a93ac5989d4cce2f20a604b86214b
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jul 2, 2025
@github-actions github-actions bot requested a review from Sajjon July 2, 2025 13:14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 2, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev
Copy link
Copy Markdown
Contributor

@Sajjon Hey Alex, could you please double check the conflicts here and one more thing - the major bumps are not allowed in the backports to the existing stable branches, could it be re-done so that there won't be a breaking change?

@Sajjon
Copy link
Copy Markdown
Contributor

Sajjon commented Jul 3, 2025

@sandreim told me to close this

@Sajjon Sajjon closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants