Merged
Conversation
rockbmb
added
the
R0-no-crate-publish-required
alexggh
approved these changes
Jun 24, 2025
bkchr
approved these changes
Jun 24, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Member
|
/cmd fmt |
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
# Description I found the previous version of the comment for the `schedule_config_update` function slightly unclear. I understood it to mean that the application of two configuration changes in the same session would lead to the change being applied in the current session, instead of having to wait until the session change as usual. I tried this out on `chopsticks` just to be sure. --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found the previous version of the comment for the
schedule_config_updatefunction slightly unclear.I understood it to mean that the application of two configuration changes in the same session would lead to the change being applied in the current session, instead of having to wait until the session change as usual.
I tried this out on
chopsticksjust to be sure.