Multisig::as_multi_threshold_1: Send MultisigExecuted event#8925
Merged
Multisig::as_multi_threshold_1: Send MultisigExecuted event#8925
MultisigExecuted event#8925Conversation
bkchr
commented
Jun 20, 2025
| let (call_len, call_hash) = call.using_encoded(|c| (c.len(), blake2_256(&c))); | ||
| let result = call.dispatch(RawOrigin::Signed(id.clone()).into()); | ||
|
|
||
| Self::deposit_event(Event::MultisigExecuted { |
Member
Author
There was a problem hiding this comment.
The only difference is that this will not appear when the call is returning an error, as we then revert all the changes. (rollback of the transaction)
Member
Author
There was a problem hiding this comment.
Talked to Valentin. He is fine with the pr how it is.
Member
Author
|
/cmd prdoc --audience runtime_user --bump patch |
…time_user --bump patch'
ggwpez
approved these changes
Jun 20, 2025
bkontur
approved these changes
Jun 20, 2025
bkchr
added
the
A4-backport-stable2506
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Jun 26, 2025
Backport #8925 into `stable2506` from bkchr. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
So the behavior is the same as `as_multi` when it comes to sending an event. Closes: #8924 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the behavior is the same as
as_multiwhen it comes to sending an event.Closes: #8924