Skip to content

[pvf-worker] Refactor execute request handling#8908

Merged
AndreiEres merged 4 commits intomasterfrom
AndreiEres/refactor-execute-request-params
Jun 25, 2025
Merged

[pvf-worker] Refactor execute request handling#8908
AndreiEres merged 4 commits intomasterfrom
AndreiEres/refactor-execute-request-params

Conversation

@AndreiEres
Copy link
Copy Markdown
Contributor

Description

Fixes #8886

PVF execution worker communication was organized into a single ExecuteRequest struct. This should improve performance: one encode/decode operation instead of four. Also, no more chance of ordering mistakes.

Integration

This is an internal refactoring of the PVF execution worker. Downstream projects will not need any code changes.

@AndreiEres AndreiEres added T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Jun 19, 2025
@AndreiEres
Copy link
Copy Markdown
Contributor Author

/cmd prdoc --audience node_dev --bump patch

Copy link
Copy Markdown
Contributor

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread polkadot/node/core/pvf/execute-worker/src/lib.rs Outdated
Copy link
Copy Markdown
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AndreiEres AndreiEres enabled auto-merge June 25, 2025 07:42
@AndreiEres AndreiEres added this pull request to the merge queue Jun 25, 2025
Merged via the queue into master with commit fe26e9e Jun 25, 2025
263 of 265 checks passed
@AndreiEres AndreiEres deleted the AndreiEres/refactor-execute-request-params branch June 25, 2025 08:59
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
# Description

Fixes #8886

PVF execution worker communication was organized into a single
ExecuteRequest struct. This should improve performance: one
encode/decode operation instead of four. Also, no more chance of
ordering mistakes.



## Integration

This is an internal refactoring of the PVF execution worker. Downstream
projects will not need any code changes.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor the argument passing to the execution worker

5 participants