Merged
Conversation
bkontur
reviewed
Jun 18, 2025
bkontur
reviewed
Jun 18, 2025
bkontur
reviewed
Jun 18, 2025
bkontur
reviewed
Jun 18, 2025
bkontur
approved these changes
Jun 18, 2025
bkontur
added
R0-no-crate-publish-required
serban300
approved these changes
Jun 19, 2025
karolk91
reviewed
Jun 19, 2025
| true | ||
| # create foreign asset pool | ||
| create_pool \ | ||
| "ws://127.0.0.1:9910" \ |
Contributor
There was a problem hiding this comment.
is it possible to use variables here instead of raw addresses ? like "${WESTEND_RPC_URL}" vs "ws://127.0.0.1:9910" so its clear which chain this is targetting
Contributor
There was a problem hiding this comment.
@karolk91 actually, a very good point :), yes, we could do this, but I am also thinking about rewriting this scripts to PAPI, so I would keep it this way for now
bkontur
reviewed
Jul 2, 2025
| 10000000000 \ | ||
| true | ||
| # create foreign asset pool | ||
| create_pool \ |
Contributor
There was a problem hiding this comment.
@antkve Anthony, cool, create_pool / add_liquidity works, but I think we need here more fixes for polkadot-sdk, please port the changes from here polkadot-fellows/runtimes#764 to the polkadot-sdk
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
Fixes: #8800 # Description Fixing bridges integration tests by setting up pool --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8800
Description
Fixing bridges integration tests by setting up pool