Skip to content

[stable2506] Backport #8833#8899

Merged
EgorPopelyaev merged 1 commit intostable2506from
backport-8833-to-stable2506
Jun 23, 2025
Merged

[stable2506] Backport #8833#8899
EgorPopelyaev merged 1 commit intostable2506from
backport-8833-to-stable2506

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

@paritytech-release-backport-bot paritytech-release-backport-bot Bot commented Jun 18, 2025

Backport #8833 into stable2506 from AndreiEres.

This backport includes a major version bump due to internal API changes that only affect the polkadot binary. Since stable2506 hasn’t been released yet and no other downstream users are impacted, the change is considered safe.

See the documentation on how to use this bot.

Fixes #677
Fixes #2399

# Description

To detect potential corruption of PVF artifacts on disk, we store their
checksums and verify if they match before execution. In case of a
mismatch, we recreate the artifact.

## Integration

In Candidate Validation, we treat the error similarly to
PossiblyInvalidError::RuntimeConstruction due to their close nature.

## Review Notes

The Black3 hashing algorithm has already been used. I believe we can
switch to twox, as suggested in the issue, because the checksum does not
need to be cryptographically hashed, and we do not reveal the checksum
in logs.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 310e81d)
@github-actions github-actions Bot added the A3-backport Pull request is already reviewed well in another branch. label Jun 18, 2025
@github-actions github-actions Bot requested a review from AndreiEres June 18, 2025 14:41
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev enabled auto-merge (squash) June 23, 2025 11:34
@EgorPopelyaev EgorPopelyaev merged commit 0431632 into stable2506 Jun 23, 2025
321 of 322 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-8833-to-stable2506 branch June 23, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants