[pallet-revive] Make Runtime call dispatchable as eth transaction#8883
[pallet-revive] Make Runtime call dispatchable as eth transaction#8883
Conversation
|
/cmd prdoc --audience runtime_dev --bump patch |
pgherveou
added
the
T7-smart_contracts
…time_dev --bump patch'
| storage_deposit_limit, | ||
| data, | ||
| if dest == RUNTIME_PALLETS_ADDR { | ||
| let call = CallOf::<Self::Config>::decode(&mut &data[..]).map_err(|_| { |
There was a problem hiding this comment.
Needs a decode_with_max_depth or something. You need to check where it is decoded elsewhere.
There was a problem hiding this comment.
probably fine to apply the same limit as in https://github.com/paritytech/polkadot-sdk/blob/pg/fix-extension-weight/substrate/frame/executive/src/lib.rs?plain=1#L801-L798
made the changes here:
eadfed3
- Use the extension_weight of the eth transact, not the transformed one in both the dry-run and Checkable trait
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
athei
left a comment
athei
left a comment
There was a problem hiding this comment.
using the encoded runtime call as input, the call will be executed by this given origin.
Meaning: Given the origin indicated by the Ethereum signature (0xEE account_id).
) Make RuntimeCall dispatchable as eth transaction. By sending a transaction to `0x6d6f646c70792f70616464720000000000000000`, using the encoded runtime call as input, the call will be executed by the origin indicated by the Ethereum signature (0xEE account_id). see paritytech/foundry-polkadot#130 e.g sending a remark_with_event ``` cast wallet import dev-account --private-key 5fb92d6e98884f76de468fa3f6278f8807c48bebc13595d45af5bdc4da702133 cast send --account dev-account 0x6d6f646c70792f70616464720000000000000000 0x0007143132333435 ``` also merged in #8901 and #8920 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
4 participants
Make RuntimeCall dispatchable as eth transaction.
By sending a transaction to
0x6d6f646c70792f70616464720000000000000000, using the encoded runtime call as input, the call will be executed by the origin indicated by the Ethereum signature (0xEE account_id).see paritytech/foundry-polkadot#130
e.g sending a remark_with_event
also merged in #8901 and #8920