[AHM-Kusama] EPMB: invulnerables and offchain storage#8877
Conversation
Have you already created an issue for that so that we can track it and we (to be read as : I...) don't forget ? |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
great point! created #8880 |
|
A general comment: I’m not sure if we are too late for this and I am fine with reviewing the PR as it is, but I would have appreciated two separate PRs, as they address two completely unrelated topics. E.g. I am done with the review of OCW part and beside a comment on a test to extend, I am pretty sure it can be merged immediately. I haven't started on the invulnerable part but that might require further discussion etc. |
Yeah let's see -- if your review of the second commit turns out complicated, I can split the PRs. |
sigurpol
left a comment
There was a problem hiding this comment.
LGTM, some minor comments mostly about adding tests.
Not a blocker on my side
It turned out to be unnecessary in the end; it was quite small. I complained for nothing. 😆 |
Follow-up to #8877 and audits: Make it such that invulnerable accounts cannot be ejected from the election signed queue altogether. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io>
Follow-up to #8877 and audits: Make it such that invulnerable accounts cannot be ejected from the election signed queue altogether. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io>
This PR bring two new features to the `election-provider-multi-block` pallets, based on audit reviews and our empirical experience in westend: 1. While I have not found the actual root cause, the offchain-worker miner in westend collators is sometimes unreliable. In this PR, I have added a configuration that would disable the call cache for this offchain worker. I have run this new code in my personal WAH collator, and it is indeed more reliable. This just gives us more lever to easily disable the cache. Investigation should still continue as to what is the root cause. 2. the signed submission system now supports a governance set of `invulnerables`. See the code comments for what this implies. Marking this as silent for now as these crates are unreleased for faster pace, but can add prdoc if needed. This will be quite useful to lower the chance of backports after #8764 deadline, but is not mandatory. It partially closes https://github.com/orgs/paritytech/projects/189?pane=issue&itemId=114585501&issue=paritytech%7Cpolkadot-sdk%7C8879 --------- Co-authored-by: Paolo La Camera <paolo@parity.io>
Follow-up to #8877 and audits: Make it such that invulnerable accounts cannot be ejected from the election signed queue altogether. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io>
This PR bring two new features to the
election-provider-multi-blockpallets, based on audit reviews and our empirical experience in westend:invulnerables. See the code comments for what this implies.Marking this as silent for now as these crates are unreleased for faster pace, but can add prdoc if needed.
This will be quite useful to lower the chance of backports after #8764 deadline, but is not mandatory.
It partially closes #8879