[FRAME] Custom log level for the runtime benchmarks#8857
Merged
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Member
Author
|
/cmd prdoc --audience runtime_dev --bump minor |
ggwpez
added
the
T12-benchmarks
…time_dev --bump minor'
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
…nto oty-omni-bencher-custom-level
bkchr
reviewed
Jun 15, 2025
| /// - Default logger settings | ||
| pub fn init(arg: Option<LevelFilter>) { | ||
| let level = arg.unwrap_or_else(|| { | ||
| if let Ok(env) = std::env::var("RUNTIME_LOG") { |
Member
There was a problem hiding this comment.
Did you tried this? From the code, it seems that FromStr for LevelFilter is only for parsing Debug etc and not something=debug?
Member
Author
There was a problem hiding this comment.
I changed it now to be a filter in the last commit a859efb
Not sure if its worth the additional complexity though, since I only added this feature to turn the annoying logs off 😆
Also the runtime filter can never have a level greater than the node filter, since it is still limited by that.
Co-authored-by: Bastian Köcher <git@kchr.de>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
bkchr
approved these changes
Jun 17, 2025
bkontur
reviewed
Jul 30, 2025
bkontur
approved these changes
Jul 30, 2025
Member
|
/cmd fmt |
bkontur
added
A4-backport-stable2503
A4-backport-stable2506
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-8857-to-stable2503
git worktree add --checkout .worktree/backport-8857-to-stable2503 backport-8857-to-stable2503
cd .worktree/backport-8857-to-stable2503
git reset --hard HEAD^
git cherry-pick -x e1d67cfe40801a893cdc27f7da0eb4e3e4fba1ce
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-8857-to-stable2506
git worktree add --checkout .worktree/backport-8857-to-stable2506 backport-8857-to-stable2506
cd .worktree/backport-8857-to-stable2506
git reset --hard HEAD^
git cherry-pick -x e1d67cfe40801a893cdc27f7da0eb4e3e4fba1ce
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-8857-to-unstable2507
git worktree add --checkout .worktree/backport-8857-to-unstable2507 backport-8857-to-unstable2507
cd .worktree/backport-8857-to-unstable2507
git reset --hard HEAD^
git cherry-pick -x e1d67cfe40801a893cdc27f7da0eb4e3e4fba1ce
git push --force-with-lease |
bkontur
added a commit
that referenced
this pull request
Jul 31, 2025
Backport #8857 into `unstable2507` from ggwpez. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Branislav Kontur <bkontur@gmail.com>
bkontur
added a commit
that referenced
this pull request
Aug 13, 2025
Backport #8857 into `stable2506` from ggwpez. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Branislav Kontur <bkontur@gmail.com>
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
Changes: - Add `--runtime-log` option to omni-bencher CLI - Read env var `RUNTIME_LOG` as fallback to the `--runtime-log` option - Set custom log level for runtime benchmarks that can be different form CLI level - Fix issue where old runtimes have a space in the pallet or instance name from breaking change in `quote` macro Note: I saw that the genesis builder is not using the provided host functions, hence it still logs things during genesis config building. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Branislav Kontur <bkontur@gmail.com>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
--runtime-logoption to omni-bencher CLIRUNTIME_LOGas fallback to the--runtime-logoptionquotemacroNote: I saw that the genesis builder is not using the provided host functions, hence it still logs things during genesis config building.