Skip to content

fatxpool: fork aware transaction pool is now default #8838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalkucharczyk merged 6 commits into from
Jun 25, 2025
+8 −1
Merged

fatxpool: fork aware transaction pool is now default #8838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ea18fb
fork aware transaction pool is now default
michalkucharczyk Jun 12, 2025
a07bc68
Update from github-actions[bot] running command 'prdoc --bump major -…
github-actions[bot] Jun 12, 2025
b8924d8
Apply suggestions from code review
michalkucharczyk Jun 13, 2025
68f13cb
Merge branch 'master' into mku-fatp-is-default
michalkucharczyk Jun 13, 2025
c354095
Merge branch 'master' into mku-fatp-is-default
michalkucharczyk Jun 17, 2025
562c28a
Merge branch 'master' into mku-fatp-is-default
michalkucharczyk Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions prdoc/pr_8838.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
title: '`fatxpool`: fork aware transaction pool is now default'
doc:
- audience: Node Operator
description: This PR changes the default transaction pool to the fork aware implementation. The old implementation can be still used with `--pool-type=single-state` command line argument.
crates:
- name: sc-cli
bump: major
Copy link
Copy Markdown
Contributor

@skunert skunert Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think minor is okay here.

2 changes: 1 addition & 1 deletion substrate/client/cli/src/params/transaction_pool_params.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ pub struct TransactionPoolParams {
pub tx_ban_seconds: Option<u64>,

/// The type of transaction pool to be instantiated.
#[arg(long, value_enum, default_value_t = TransactionPoolType::SingleState)]
#[arg(long, value_enum, default_value_t = TransactionPoolType::ForkAware)]
pub pool_type: TransactionPoolType,
}

Expand Down
Loading