fatxpool: report_invalid is now aync#8836
Merged
michalkucharczyk merged 7 commits intomasterfrom Jun 25, 2025
Merged
Conversation
1 task
michalkucharczyk
force-pushed
the
mku-report-invalid-is-async
branch
from
8506c81 to
1d78644
Compare
Contributor
Author
|
/cmd prdoc --bump major --audience node_dev |
…-audience node_dev'
Contributor
Author
|
@iulianbarbu @skunert: I extracted API changes from #8596 to this PR, so #8596 does not change the API of txpool (and can be easily backported). |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
michalkucharczyk
added
T0-node
bkchr
approved these changes
Jun 15, 2025
skunert
approved these changes
Jun 18, 2025
Contributor
Author
|
Please don't merge this one yet. We first need to merge some fixes (to avoid conflicts with backports). |
iulianbarbu
approved these changes
Jun 22, 2025
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
[`TransactionPool::report_invalid`](https://github.com/paritytech/polkadot-sdk/blob/74dafaee5c600fd2c8a59a280f647f94ccf0a755/substrate/client/transaction-pool/api/src/lib.rs#L314) is now `async`, function was typically used in async context, seems right to be fully async. _Note_: expected to be merged after: #8596 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TransactionPool::report_invalidis nowasync, function was typically used in async context, seems right to be fully async.Note: expected to be merged after: #8596