-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[AHM] Report the weights of epmb pallet to expose kusama and polkadot weights #8704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
88ce3db
repot the weights of epmb pallet to expose kusama and polkadot specif…
kianenigma 502a9df
update all weights on a refhw
kianenigma 01eb418
Merge branch 'master' into kiz-redo-staking-async-epmb-weights
kianenigma 414e9ed
fmt
kianenigma fbe8812
Update from github-actions[bot] running command 'prdoc --bump major'
github-actions[bot] f884ed1
Merge branch 'kiz-redo-staking-async-epmb-weights' of github.com:pari…
kianenigma 6be4751
fix some tests
kianenigma ede3d42
Merge branch 'master' into kiz-redo-staking-async-epmb-weights
kianenigma 50e3dba
Fix prdoc's audience
sigurpol 04daa4e
fix template and prdoc
kianenigma a532d40
Merge branch 'kiz-redo-staking-async-epmb-weights' of github.com:pari…
kianenigma 99e8131
Merge branch 'master' into kiz-redo-staking-async-epmb-weights
kianenigma 87685a8
Merge branch 'master' into kiz-redo-staking-async-epmb-weights
kianenigma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
substrate/frame/election-provider-multi-block/src/template.hbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| // This file is part of Substrate. | ||
|
|
||
| // Copyright (C) Parity Technologies (UK) Ltd. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| {{header}} | ||
| //! Autogenerated weights for `{{pallet}}` | ||
| //! | ||
| //! (THIS IS A SPECIAL TEMPLATE FOR `election-provider-multi-block` PALLET) | ||
| //! | ||
| //! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION {{version}} | ||
| //! DATE: {{date}}, STEPS: `{{cmd.steps}}`, REPEAT: `{{cmd.repeat}}`, LOW RANGE: `{{cmd.lowest_range_values}}`, HIGH RANGE: `{{cmd.highest_range_values}}` | ||
| //! WORST CASE MAP SIZE: `{{cmd.worst_case_map_values}}` | ||
| //! HOSTNAME: `{{hostname}}`, CPU: `{{cpuname}}` | ||
| //! WASM-EXECUTION: `{{cmd.wasm_execution}}`, CHAIN: `{{cmd.chain}}`, DB CACHE: `{{cmd.db_cache}}` | ||
|
|
||
| // Executed Command: | ||
| {{#each args as |arg|}} | ||
| // {{arg}} | ||
| {{/each}} | ||
|
|
||
| #![cfg_attr(rustfmt, rustfmt_skip)] | ||
| #![allow(unused_parens)] | ||
| #![allow(unused_imports)] | ||
| #![allow(missing_docs)] | ||
| #![allow(dead_code)] | ||
|
|
||
| use frame_support::{traits::Get, weights::{Weight, constants::RocksDbWeight}}; | ||
| use core::marker::PhantomData; | ||
|
|
||
| /// Weights for `{{pallet}}`. | ||
| pub struct WeightInfo<T>(PhantomData<T>); | ||
| {{#if (or (eq pallet "frame_system") (eq pallet "frame_system_extensions"))}} | ||
| impl<T: crate::Config> WeightInfo for WeightInfo<T> { | ||
| {{else}} | ||
| impl<T: frame_system::Config> crate::weights::traits::{{pallet}}::WeightInfo for WeightInfo<T> { | ||
| {{/if}} | ||
| {{#each benchmarks as |benchmark|}} | ||
| {{#each benchmark.comments as |comment|}} | ||
| /// {{comment}} | ||
| {{/each}} | ||
| {{#each benchmark.component_ranges as |range|}} | ||
| /// The range of component `{{range.name}}` is `[{{range.min}}, {{range.max}}]`. | ||
| {{/each}} | ||
| fn {{benchmark.name~}} | ||
| ( | ||
| {{~#each benchmark.components as |c| ~}} | ||
| {{~#if (not c.is_used)}}_{{/if}}{{c.name}}: u32, {{/each~}} | ||
| ) -> Weight { | ||
| // Proof Size summary in bytes: | ||
| // Measured: `{{benchmark.base_recorded_proof_size}}{{#each benchmark.component_recorded_proof_size as |cp|}} + {{cp.name}} * ({{cp.slope}} ±{{underscore cp.error}}){{/each}}` | ||
| // Estimated: `{{benchmark.base_calculated_proof_size}}{{#each benchmark.component_calculated_proof_size as |cp|}} + {{cp.name}} * ({{cp.slope}} ±{{underscore cp.error}}){{/each}}` | ||
| // Minimum execution time: {{underscore benchmark.min_execution_time}}_000 picoseconds. | ||
| Weight::from_parts({{underscore benchmark.base_weight}}, {{benchmark.base_calculated_proof_size}}) | ||
| {{#each benchmark.component_weight as |cw|}} | ||
| // Standard Error: {{underscore cw.error}} | ||
| .saturating_add(Weight::from_parts({{underscore cw.slope}}, 0).saturating_mul({{cw.name}}.into())) | ||
| {{/each}} | ||
| {{#if (ne benchmark.base_reads "0")}} | ||
| .saturating_add(T::DbWeight::get().reads({{benchmark.base_reads}}_u64)) | ||
| {{/if}} | ||
| {{#each benchmark.component_reads as |cr|}} | ||
| .saturating_add(T::DbWeight::get().reads(({{cr.slope}}_u64).saturating_mul({{cr.name}}.into()))) | ||
| {{/each}} | ||
| {{#if (ne benchmark.base_writes "0")}} | ||
| .saturating_add(T::DbWeight::get().writes({{benchmark.base_writes}}_u64)) | ||
| {{/if}} | ||
| {{#each benchmark.component_writes as |cw|}} | ||
| .saturating_add(T::DbWeight::get().writes(({{cw.slope}}_u64).saturating_mul({{cw.name}}.into()))) | ||
| {{/each}} | ||
| {{#each benchmark.component_calculated_proof_size as |cp|}} | ||
| .saturating_add(Weight::from_parts(0, {{cp.slope}}).saturating_mul({{cp.name}}.into())) | ||
| {{/each}} | ||
| } | ||
| {{/each}} | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 10 additions & 17 deletions
27
substrate/frame/election-provider-multi-block/src/weights/comp_weights.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,21 @@ | ||
|
|
||
| function display { | ||
| echo "comparing $1 -> $2" | ||
| subweight compare files \ | ||
| --method asymptotic \ | ||
| --new $1 \ | ||
| --old $2 \ | ||
| --unit proof --verbose --threshold 0 | ||
|
|
||
| # subweight compare files \ | ||
| # --method asymptotic \ | ||
| # --new $1 \ | ||
| # --old $2 \ | ||
| # --unit time --verbose --threshold 0 | ||
| subweight compare files \ | ||
| --method asymptotic \ | ||
| --new $1 \ | ||
| --old $2 \ | ||
| --unit time --verbose --threshold 0 | ||
| } | ||
|
|
||
| ## Polkadot | ||
|
|
||
| echo "#### new: polkadot/pallet_election_provider_multi_block.rs old: kusama" | ||
| display "polkadot/measured/pallet_election_provider_multi_block.rs" "kusama/measured/pallet_election_provider_multi_block.rs" | ||
|
|
||
| echo "#### new: polkadot/pallet_election_provider_multi_block_signed.rs old: kusama" | ||
| display "polkadot/measured/pallet_election_provider_multi_block_signed.rs" "kusama/measured/pallet_election_provider_multi_block_signed.rs" | ||
|
|
||
| echo "#### new: polkadot/pallet_election_provider_multi_block_unsigned.rs old: kusama" | ||
| display "polkadot/measured/pallet_election_provider_multi_block_unsigned.rs" "kusama/measured/pallet_election_provider_multi_block_unsigned.rs" | ||
|
|
||
| echo "#### new: polkadot/pallet_election_provider_multi_block_verifier.rs old: kusama" | ||
| display "polkadot/measured/pallet_election_provider_multi_block_verifier.rs" "kusama/measured/pallet_election_provider_multi_block_verifier.rs" | ||
| display "./pallet_election_provider_multi_block_dot_size.rs" "./pallet_election_provider_multi_block_ksm_size.rs" | ||
| display "./pallet_election_provider_multi_block_signed_dot_size.rs" "./pallet_election_provider_multi_block_signed_ksm_size.rs" | ||
| display "./pallet_election_provider_multi_block_unsigned_dot_size.rs" "./pallet_election_provider_multi_block_unsigned_ksm_size.rs" | ||
| display "./pallet_election_provider_multi_block_verifier_dot_size.rs" "./pallet_election_provider_multi_block_verifier_ksm_size.rs" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add one comment here please on why we need to copy it instead of using the default template?
I assume that we need to tell the bench bot about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we cannot benchmark this pallet in CI yet because it requires a large genesis config to be set in the runtime, and I didn't want to deal with configuring that yet. The large genesis config would slow down all benchmarks if created for all, and I don't know the exact syntax to make it an option just for this pallet in the bench CI.
Atm the only reason to have this separate template is because I don't want the
trait WeightIfo.