-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add optional auto-rebag within on-idle #8684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nkpar
merged 85 commits into
master
from
8403-pallet-bags-list-add-optional-auto-rebag-within-on-idle
Jul 1, 2025
Merged
Changes from all commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
5fc47a9
WIP
nkpar ca81567
kitchensink-runtime adoption
nkpar 6b6e572
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 6977e70
Review comments and runtimes support
nkpar 40fe3ef
Merge branch '8403-pallet-bags-list-add-optional-auto-rebag-within-on…
nkpar 1f6943f
Update auto-rebagging logic and refine related comments
nkpar 094da4d
Update from github-actions[bot] running command 'fmt'
github-actions[bot] ec01134
Update from github-actions[bot] running command 'prdoc --audience run…
github-actions[bot] c88dc5b
Update pr_8684.prdoc
nkpar cadf8c8
Update mock.rs
nkpar d118b26
Update lib.rs
nkpar a552dae
Update from github-actions[bot] running command 'fmt'
github-actions[bot] c2b6cc7
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
Ank4n 4f86865
Refactor `rebag_internal` and improve mocs readability
nkpar 296fe0c
Update lib.rs
nkpar 3bd16a0
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 1ded36a
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 771e3c2
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 411be09
Update lib.rs
nkpar 9209ec7
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 56e508a
Update lib.rs
nkpar 89d0be9
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar a8dec03
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 27a95a1
broken tests
nkpar f9b150a
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 5bb735b
Tests and new logic
nkpar f0306fb
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar abc1438
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 3c40eac
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 5e71b3e
Remove `iter_from_inclusive` and refactor auto-rebagging logic
nkpar 50fd2bb
Update substrate/frame/bags-list/src/lib.rs
nkpar f761e3b
benchmarking, refactor auto-rebagging, and update weight configurations
nkpar 2836fe1
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar d3b73c7
Update pallet_bags_list.rs
nkpar 8ba3c5d
Merge branch '8403-pallet-bags-list-add-optional-auto-rebag-within-on…
nkpar befa890
Refactor `on_idle` logic and benchmarks
nkpar 6fdc7ce
Update from github-actions[bot] running command 'bench --pallet palle…
github-actions[bot] 4dab54a
Refactor `on_idle` benchmark
nkpar 87e2e0f
Update benchmarks.rs
nkpar d719418
Update benchmarks.rs
nkpar 8f52009
Update benchmarks.rs
nkpar 54dce3e
Update from github-actions[bot] running command 'bench --pallet palle…
github-actions[bot] b1a36fe
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar a1cbe49
Integrate `AutoRebagPerBlock` configuration into mock runtimes
nkpar 0b2d64a
Merge branch '8403-pallet-bags-list-add-optional-auto-rebag-within-on…
nkpar 015fb50
Update mock.rs
nkpar 379ce97
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar d4b10b6
Update pr_8684.prdoc
nkpar 80c1809
Update substrate/frame/bags-list/src/lib.rs
nkpar e71c34f
Update pr_8684.prdoc
nkpar c2a233a
Merge branch '8403-pallet-bags-list-add-optional-auto-rebag-within-on…
nkpar 2f9b19d
Update pr_8684.prdoc
nkpar 545fbc0
Refine `System::events` assertions and disable auto-rebagging for tes…
nkpar 2960b0f
Update basic.rs
nkpar a9ba4b6
Disable `AutoRebagNumber` in other mocks
nkpar b13eefb
Update lib.rs
nkpar a9df14a
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 91e430a
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar f5ad62d
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 4b68e86
Update import.rs
nkpar d1984de
Merge branch '8403-pallet-bags-list-add-optional-auto-rebag-within-on…
nkpar 1f34e12
Update tests-misc.yml
nkpar 8f1d688
Update tests-misc.yml
nkpar de292c9
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 1f4f5ff
Rename `AutoRebagPerBlock` to `MaxAutoRebagPerBlock` across the codeb…
nkpar 357b4e4
MaxAutoRebagPerBlock
nkpar 8170020
bags-list: optimize fast-exit path in on_idle by reordering checks
nkpar baa5017
bags-list: clarify on_idle weight assumptions and benchmarking depend…
nkpar 75b7672
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar c757f79
Update substrate/frame/bags-list/src/tests.rs
nkpar 8595603
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 55c189b
Update substrate/frame/bags-list/src/benchmarks.rs
nkpar 9ff2260
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 386d808
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar afee4b9
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar d74f4ee
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar 973b2d3
Update from github-actions[bot] running command 'bench --pallet palle…
github-actions[bot] 546f59d
Update staking.rs
nkpar 07cdb28
Update from github-actions[bot] running command 'bench --pallet palle…
github-actions[bot] 52b2c31
Merge branch 'master' into 8403-pallet-bags-list-add-optional-auto-re…
nkpar a55c315
Update from github-actions[bot] running command 'bench --pallet palle…
github-actions[bot] 8567bac
Update pallet_bags_list.rs
nkpar f821f23
Merge branch '8403-pallet-bags-list-add-optional-auto-rebag-within-on…
nkpar b8f0f10
Update pr_8684.prdoc
nkpar 50e930b
Update from github-actions[bot] running command 'bench --pallet palle…
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| title: Add optional auto-rebag within on-idle | ||
| doc: | ||
| - audience: Runtime Dev | ||
| description: Introduced an optional `on_idle` hook for automatic account rebagging, | ||
| improving the incremental correction of account positions within the bags-list | ||
| during block execution's idle phase. This feature leverages new storage and | ||
| configurable constants, alongside enhanced logging and internal helpers. | ||
| Setting `MaxAutoRebagPerBlock` to `0` (e.g., `type MaxAutoRebagPerBlock = ();`) | ||
| disables this functionality, preserving pre-upgrade pallet behavior. | ||
| make sure that after setting value of `MaxAutoRebagPerBlock` you regenerate weight for your runtime. | ||
| crates: | ||
| - name: pallet-bags-list | ||
| bump: major | ||
| - name: westend-runtime | ||
| bump: minor | ||
| - name: pallet-staking-async-parachain-runtime | ||
| bump: minor | ||
| - name: pallet-staking-async-rc-runtime | ||
| bump: minor | ||
| - name: pallet-staking | ||
| bump: minor | ||
| - name: pallet-nomination-pools-benchmarking | ||
| bump: minor | ||
| - name: pallet-staking-async | ||
| bump: minor | ||
| - name: asset-hub-westend-runtime | ||
| bump: minor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.