Skip to content

[stable2503] Backport #8473#8665

Merged
EgorPopelyaev merged 5 commits intostable2503from
backport-8473-to-stable2503
Jun 2, 2025
Merged

[stable2503] Backport #8473#8665
EgorPopelyaev merged 5 commits intostable2503from
backport-8473-to-stable2503

Conversation

@paritytech-release-backport-bot

Backport #8473 into stable2503 from yrong.

See the documentation on how to use this bot.

The `TokenIdOf`
[convert](https://github.com/paritytech/polkadot-sdk/blob/4b83d24f4bc96a7b17964be94b178dd7b8f873b5/bridges/snowbridge/primitives/core/src/location.rs#L40)
is XCM version-agnostic, meaning we will get the same token ID for both
V5 and legacy V4 asset.

However, the extra check is unnecessary, as
the`ConvertAssetId::convert(&token_id).ok_or(InvalidAsset)?;` alone is
sufficient to verify whether the token is registered.

(cherry picked from commit 64aed49)
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label May 27, 2025
@paritytech-review-bot paritytech-review-bot bot requested a review from a team May 27, 2025 08:46
@github-actions
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev
Copy link
Contributor

@yrong
Copy link
Contributor

yrong commented May 28, 2025

@yrong Could you please double-check failing tests: https://github.com/paritytech/polkadot-sdk/actions/runs/15270732142/job/42945690820?pr=8665#step:4:38

Thanks for checking! Here is the fix: #8690

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/15297821417
Failed job name: cargo-clippy

@EgorPopelyaev EgorPopelyaev enabled auto-merge (squash) May 30, 2025 05:50
@EgorPopelyaev EgorPopelyaev merged commit bdb7939 into stable2503 Jun 2, 2025
204 of 208 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-8473-to-stable2503 branch June 2, 2025 09:38
alstjd0921 pushed a commit to bifrost-platform/polkadot-sdk that referenced this pull request Aug 14, 2025
Backport paritytech#8473 into `stable2503` from yrong.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Ron <yrong1997@gmail.com>
Co-authored-by: Egor_P <egor@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants