txpool: fix tx removal from unlocks set#8500
Merged
iulianbarbu merged 17 commits intoparitytech:masterfrom May 21, 2025
Merged
Conversation
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
iulianbarbu
changed the title
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Contributor
Author
|
/cmd prdoc |
Contributor
Author
|
/cmd fmt |
Contributor
|
Command "fmt" has failed ❌! See logs here |
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
michalkucharczyk
approved these changes
May 16, 2025
Contributor
|
note - just for the record - I think this bug was not causing any user-facing problems. Not removing transactions from unlocks set deep in |
Contributor
Author
Fair point. Nonetheless, as we agreed offline, the logic is clearly flawed, so it makes sense to fix it and the unit test should ensure the new logic holds true. |
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
skunert
approved these changes
May 20, 2025
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Merged
via the queue into
paritytech:master
with commit May 21, 2025
e44b89f
243 of 245 checks passed
ordian
added a commit
that referenced
this pull request
May 27, 2025
* master: (99 commits) Snowbridge: Remove asset location check for compatibility (#8473) add poke_deposit extrinsic to pallet-bounties (#8382) litep2p/peerset: Reject non-reserved peers in the reserved-only mode (#8650) Charge deposit based on key length (#8648) [pallet-revive] make subscription task panic on error (#8587) tx/metrics: Add metrics for the RPC v2 `transactionWatch_v1_submitAndWatch` (#8345) Bridges: Fix - Improve try-state for pallet-xcm-bridge-hub (#8615) Introduce CreateBare, deprecated CreateInherent (#7597) Use hashbrown hashmap/hashset in validation context (#8606) ci: rm gitlab config (#8622) 🔪 flaky and Zombienet tests (#8600) cumulus: adjust unincluded segment size metric buckets (#8617) Benchmark storage access on block validation (#8069) Revert 7934 es/remove tj changes (#8611) collator-protocol: add more collation observability (#8230) `fatxpool`: add fallback for ready at light (#8533) txpool: fix tx removal from unlocks set (#8500) XCMP weight metering: account for the MQ page position (#8344) fix epmb solution duplicate issue + add remote mining apparatus to epm (#8585) Fix generated address returned by Substrate RPC runtime call (#8504) ...
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
# Description Removing a tx subtree means partly removing some txs from the unlocks set of other txs. This logic is buggy and the PR attempts to fix it. Closes #8498 ## Integration N/A ## Review Notes This doesn't seem to be an important bug. Unit tests for txpool still pass after the fix, so txpool behavior isn't changing much. ### TODOs - [x] test with a heavy load test (5 millions txs) - all txs were validated successfully - [x] added a unit test --------- Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing a tx subtree means partly removing some txs from the unlocks set of other txs. This logic is buggy and the PR attempts to fix it.
Closes #8498
Integration
N/A
Review Notes
This doesn't seem to be an important bug. Unit tests for txpool still pass after the fix, so txpool behavior isn't changing much.
TODOs