Conversation
|
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-8240-to-stable2503
git worktree add --checkout .worktree/backport-8240-to-stable2503 backport-8240-to-stable2503
cd .worktree/backport-8240-to-stable2503
git reset --hard HEAD^
git cherry-pick -x 632eed96b4560a45ce41c6f6bedec9a4c745a604
git push --force-with-lease |
github-actions
bot
added
the
A3-backport
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
| let message = Message { | ||
| origin, | ||
| id: Default::default(), | ||
| id: frame_system::unique((origin, &command, fee)).into(), |
There was a problem hiding this comment.
I'd assume the ID should be generated by the system-frontend pallet on AH here, along with an additional setTopic instruction using a provided ID.
Another issue is that the current register_token call is free, which may not be the intended behavior.
To address this, we could consider introducing a higher-level extrinsic in the system-v2 pallet, and have system-frontend call that entry point - passing in the necessary context such as the fee (for burning) and topic_id (for tracing). This wrapper would internally call functions like register_token or add_tip, as seen in PR #8271.
This isn’t specific to this backport PR and is non-blocking, just my two cents; we can revisit and improve it later.
There was a problem hiding this comment.
Ron can you open a ticket to track this?
There was a problem hiding this comment.
| GatewayProxyAddress, | ||
| EthereumUniversalLocation, | ||
| GlobalAssetHubLocation, | ||
| AssetHubFromEthereum, |
There was a problem hiding this comment.
nit: Can you add a ticket to document the difference between AssetHubFromEthereum and AssetHubUniversalLocation, with an example values?
The other generic parameters could also do with more documentation.
There was a problem hiding this comment.
There was a problem hiding this comment.
In addition to updating the documentation, I'd suggest refactoring and reorganizing the generics here for clarity.
Original comment: #8240 (comment) and I've created a ticket for tracking: https://linear.app/snowfork/issue/SNO-1498
There was a problem hiding this comment.
Agree, some refactoring is needed 👍
Backport paritytech#8240 into `stable2503` from claravanstaden. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>
5 participants
Backport #8240 into
stable2503from claravanstaden.See the documentation on how to use this bot.