Remove TakeFirstAssetTrader from AH Westend and Rococo#8376
Conversation
...s/parachains/integration-tests/emulated/tests/assets/asset-hub-westend/src/tests/transact.rs
Show resolved
Hide resolved
|
if it comes to |
...s/parachains/integration-tests/emulated/tests/assets/asset-hub-westend/src/tests/transact.rs
Show resolved
Hide resolved
cumulus/parachains/integration-tests/emulated/tests/assets/asset-hub-westend/src/tests/mod.rs
Outdated
Show resolved
Hide resolved
…idity pool (#8392) Used macro overloading instead of two macros
…y. Fixed a test that needed liquidity pool
|
I modified runtime test.
|
franciscoaguirre
left a comment
There was a problem hiding this comment.
It's fine to remove those tests. We no longer use sufficient assets for fee payment, we always use liquidity pools, and we have tests for using liquidity pools to swap for fee payment already
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
cumulus/parachains/integration-tests/emulated/tests/assets/asset-hub-rococo/src/tests/mod.rs
Show resolved
Hide resolved
TakeFirstAssetTrader from configs. Improved macros, fixed tests.
TakeFirstAssetTrader from configs. Improved macros, fixed tests.TakeFirstAssetTrader from Asset Hubs configs. Improved macros, fixed tests.
TakeFirstAssetTrader from Asset Hubs configs. Improved macros, fixed tests.TakeFirstAssetTrader from Asset Hubs configs
Co-authored-by: Adrian Catangiu <adrian@parity.io>
TakeFirstAssetTrader from Asset Hubs configs## Description Removed `TakeFirstAssetTrader` from Asset Hub Westend and Rococo. Improved macros, fixed tests. This implies asset sufficiency no longer guarantees that weight can also be bought with it. `SwapFirstAssetTrader` is used instead which will attempt to swap some of the given asset for the required amount of native asset to buy weight. This may or may not succeed depending on whether there is a local pool present with enough liquidity to serve the swap. ## Review notes Additionally parametrised macro and fixed Westend test: weight swapping was failing at [this line](https://github.com/paritytech/polkadot-sdk/blob/44ae6a8bebd23a8ffac02d71c6e74ee889c3ab00/substrate/frame/asset-conversion/src/lib.rs#L903) with around 100x difference thus had to modify the macro. Fixes #8233 --------- Co-authored-by: Adrian Catangiu <adrian@parity.io>
Description
Removed
TakeFirstAssetTraderfrom Asset Hub Westend and Rococo. Improved macros, fixed tests.This implies asset sufficiency no longer guarantees that weight can also be bought with it.
SwapFirstAssetTraderis used instead which will attempt to swap some of the given asset for the required amount of native asset to buy weight. This may or may not succeed depending on whether there is a local pool present with enough liquidity to serve the swap.Review notes
Additionally parametrised macro and fixed Westend test: weight swapping was failing at this line with around 100x difference thus had to modify the macro.
Fixes #8233