Fix faulty pre-upgrade migration check in pallet-session #8294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ank4n
added
R0-no-crate-publish-required
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
bkchr
approved these changes
Apr 22, 2025
Ank4n
added
the
A4-backport-stable2503
tdimitrov
approved these changes
Apr 23, 2025
kianenigma
approved these changes
Apr 23, 2025
acatangiu
approved these changes
Apr 23, 2025
paritytech-release-backport-bot bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
More context: #7581 (comment) This check was incorrect and has been removed. It does not affect any on-chain logic. It’s also worth highlighting that CI didn’t catch this due to the issue described in #8291. I’ve verified locally that the pre-upgrade check fails with the faulty assertion and passes once it’s removed. Follow-up: We should consider at least a short-term fix to ensure CI reliably runs both pre- and post-migration checks. (cherry picked from commit 577608a)
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Apr 25, 2025
Backport #8294 into `stable2503` from Ank4n. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Ankan <[email protected]>
ordian
added a commit
that referenced
this pull request
Apr 28, 2025
* master: (120 commits) [CI] Improve GH build status checking (#8331) [CI/CD] Use original PR name in prdoc check for the backport PR's to the stable branches (#8329) Add new host APIs set_storage_or_clear and get_storage_or_zero (#7857) push to dockerhub (#8322) Snowbridge - V1 - Adds 2 hop transfer to Rococo (#7956) [AHM] Prepare `election-provider-multi-block` for full lazy data deletion (#8304) Check umbrella version (#8250) [AHM] Fully bound staking async (#8303) migrate parachain-templates tests to `gha` (#8226) staking-async: add missing new_session_genesis (#8310) New NFT traits: granular and abstract interface (#5620) Extract create_pool_with_native_on macro to common crate (#8289) XCMP: use batching when enqueuing inbound messages (#8021) Snowbridge - Tests refactor (#8014) Allow configuration of worst case buy execution weight (#7944) Fix faulty pre-upgrade migration check in pallet-session (#8294) [pallet-revive] add get_storage_var_key for variable-sized keys (#8274) add poke_deposit extrinsic to pallet-recovery (#7882) `txpool`: use tracing for structured logging (#8001) [revive] eth-rpc refactoring (#8148) ...
castillax
pushed a commit
that referenced
this pull request
May 12, 2025
More context: #7581 (comment) This check was incorrect and has been removed. It does not affect any on-chain logic. It’s also worth highlighting that CI didn’t catch this due to the issue described in #8291. I’ve verified locally that the pre-upgrade check fails with the faulty assertion and passes once it’s removed. Follow-up: We should consider at least a short-term fix to ensure CI reliably runs both pre- and post-migration checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More context: #7581 (comment)
This check was incorrect and has been removed. It does not affect any on-chain logic.
It’s also worth highlighting that CI didn’t catch this due to the issue described in #8291. I’ve verified locally that the pre-upgrade check fails with the faulty assertion and passes once it’s removed.
Follow-up: We should consider at least a short-term fix to ensure CI reliably runs both pre- and post-migration checks.