Skip to content

Backport: make macro expansion not rely on sp-std in scope.#8156

Merged
EgorPopelyaev merged 3 commits intostable2412from
gui-backport-macro
Apr 7, 2025
Merged

Backport: make macro expansion not rely on sp-std in scope.#8156
EgorPopelyaev merged 3 commits intostable2412from
gui-backport-macro

Conversation

@gui1117
Copy link
Contributor

@gui1117 gui1117 commented Apr 4, 2025

make macro in bp-runtime no longer require sp-std in scope.

)

make macro in bp-runtime no longer require `sp-std` in scope.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@gui1117
Copy link
Contributor Author

gui1117 commented Apr 4, 2025

/cmd prdoc --audience runtime_dev --bump patch

@paritytech-review-bot paritytech-review-bot bot requested a review from a team April 4, 2025 01:57
@gui1117 gui1117 added the A3-backport Pull request is already reviewed well in another branch. label Apr 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@gui1117
Copy link
Contributor Author

gui1117 commented Apr 4, 2025

But CI doesn't seem happy, it is not necessary for the merge right?

@EgorPopelyaev EgorPopelyaev merged commit baa2214 into stable2412 Apr 7, 2025
181 of 200 checks passed
@EgorPopelyaev EgorPopelyaev deleted the gui-backport-macro branch April 7, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants