xcm-emulator improved callback triggering (on_initialize, on_finalize, on_idle, OnSystemEvent).#8083
Merged
Conversation
…arachain would be processed
… pallets (and not just parachain_system)
bkontur
added
T6-XCM
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
bkontur
commented
Mar 28, 2025
bkontur
added a commit
that referenced
this pull request
Mar 31, 2025
Process `set_validation_data` and `Timestamp::set` as inherents for parachain would be processed Remove unnecessary import Process `on_initialize` / `on_finalize` / `on_idle` for all parachain pallets (and not just parachain_system) Cargo.lock
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
bkontur
added a commit
that referenced
this pull request
Apr 2, 2025
Process `set_validation_data` and `Timestamp::set` as inherents for parachain would be processed Remove unnecessary import Process `on_initialize` / `on_finalize` / `on_idle` for all parachain pallets (and not just parachain_system) Cargo.lock
bkchr
reviewed
Apr 2, 2025
bkontur
added a commit
that referenced
this pull request
Apr 2, 2025
Process `set_validation_data` and `Timestamp::set` as inherents for parachain would be processed Remove unnecessary import Process `on_initialize` / `on_finalize` / `on_idle` for all parachain pallets (and not just parachain_system) Cargo.lock
bkontur
added a commit
that referenced
this pull request
Apr 2, 2025
Process `set_validation_data` and `Timestamp::set` as inherents for parachain would be processed Remove unnecessary import Process `on_initialize` / `on_finalize` / `on_idle` for all parachain pallets (and not just parachain_system) Cargo.lock
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jun 5, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jun 5, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jun 5, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jun 5, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jun 5, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jun 5, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jun 5, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jun 5, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jun 5, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jun 5, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
…mulator (#8809) With the addition of #8083 there is no possibility right now of making the xcm-executor work with custom inherents. Custom inherents are usually driven by killing a storage item of the form `wasInherentSet` `on_initialize` and asserting that such inherent was set `on_finalize`. Before the xcm-emulator worked as these hooks were running just for the ParachainSystem pallet, but now, they run for all pallets. My proposal is to add an item to the xcm-emulator parachain configuration of the form `AdditionalInherentCode`, which simply executes code that returns a `DispatchResult`. Whether users want to mock a storage item or run the inherent is up to them, this hook would allow them to do both. This item is optional, meaning that if it is non-set then it would do nothing --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jun 24, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jun 26, 2025
…mulator (paritytech#8809) With the addition of paritytech#8083 there is no possibility right now of making the xcm-executor work with custom inherents. Custom inherents are usually driven by killing a storage item of the form `wasInherentSet` `on_initialize` and asserting that such inherent was set `on_finalize`. Before the xcm-emulator worked as these hooks were running just for the ParachainSystem pallet, but now, they run for all pallets. My proposal is to add an item to the xcm-emulator parachain configuration of the form `AdditionalInherentCode`, which simply executes code that returns a `DispatchResult`. Whether users want to mock a storage item or run the inherent is up to them, this hook would allow them to do both. This item is optional, meaning that if it is non-set then it would do nothing --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jul 2, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
dimartiro
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jul 2, 2025
…mulator (paritytech#8809) With the addition of paritytech#8083 there is no possibility right now of making the xcm-executor work with custom inherents. Custom inherents are usually driven by killing a storage item of the form `wasInherentSet` `on_initialize` and asserting that such inherent was set `on_finalize`. Before the xcm-emulator worked as these hooks were running just for the ParachainSystem pallet, but now, they run for all pallets. My proposal is to add an item to the xcm-emulator parachain configuration of the form `AdditionalInherentCode`, which simply executes code that returns a `DispatchResult`. Whether users want to mock a storage item or run the inherent is up to them, this hook would allow them to do both. This item is optional, meaning that if it is non-set then it would do nothing --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
alstjd0921
pushed a commit
to bifrost-platform/polkadot-sdk
that referenced
this pull request
Aug 14, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
tmpolaczyk
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Sep 17, 2025
Backport paritytech#8083 into `stable2503` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
tmpolaczyk
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Sep 17, 2025
…mulator (paritytech#8809) With the addition of paritytech#8083 there is no possibility right now of making the xcm-executor work with custom inherents. Custom inherents are usually driven by killing a storage item of the form `wasInherentSet` `on_initialize` and asserting that such inherent was set `on_finalize`. Before the xcm-emulator worked as these hooks were running just for the ParachainSystem pallet, but now, they run for all pallets. My proposal is to add an item to the xcm-emulator parachain configuration of the form `AdditionalInherentCode`, which simply executes code that returns a `DispatchResult`. Whether users want to mock a storage item or run the inherent is up to them, this hook would allow them to do both. This item is optional, meaning that if it is non-set then it would do nothing --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
tmpolaczyk
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Sep 17, 2025
…mulator (paritytech#8809) With the addition of paritytech#8083 there is no possibility right now of making the xcm-executor work with custom inherents. Custom inherents are usually driven by killing a storage item of the form `wasInherentSet` `on_initialize` and asserting that such inherent was set `on_finalize`. Before the xcm-emulator worked as these hooks were running just for the ParachainSystem pallet, but now, they run for all pallets. My proposal is to add an item to the xcm-emulator parachain configuration of the form `AdditionalInherentCode`, which simply executes code that returns a `DispatchResult`. Whether users want to mock a storage item or run the inherent is up to them, this hook would allow them to do both. This item is optional, meaning that if it is non-set then it would do nothing --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
tmpolaczyk
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Sep 18, 2025
…mulator (paritytech#8809) With the addition of paritytech#8083 there is no possibility right now of making the xcm-executor work with custom inherents. Custom inherents are usually driven by killing a storage item of the form `wasInherentSet` `on_initialize` and asserting that such inherent was set `on_finalize`. Before the xcm-emulator worked as these hooks were running just for the ParachainSystem pallet, but now, they run for all pallets. My proposal is to add an item to the xcm-emulator parachain configuration of the form `AdditionalInherentCode`, which simply executes code that returns a `DispatchResult`. Whether users want to mock a storage item or run the inherent is up to them, this hook would allow them to do both. This item is optional, meaning that if it is non-set then it would do nothing --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
…mulator (#8809) With the addition of #8083 there is no possibility right now of making the xcm-executor work with custom inherents. Custom inherents are usually driven by killing a storage item of the form `wasInherentSet` `on_initialize` and asserting that such inherent was set `on_finalize`. Before the xcm-emulator worked as these hooks were running just for the ParachainSystem pallet, but now, they run for all pallets. My proposal is to add an item to the xcm-emulator parachain configuration of the form `AdditionalInherentCode`, which simply executes code that returns a `DispatchResult`. Whether users want to mock a storage item or run the inherent is up to them, this hook would allow them to do both. This item is optional, meaning that if it is non-set then it would do nothing --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
tmpolaczyk
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jan 15, 2026
…mulator (paritytech#8809) With the addition of paritytech#8083 there is no possibility right now of making the xcm-executor work with custom inherents. Custom inherents are usually driven by killing a storage item of the form `wasInherentSet` `on_initialize` and asserting that such inherent was set `on_finalize`. Before the xcm-emulator worked as these hooks were running just for the ParachainSystem pallet, but now, they run for all pallets. My proposal is to add an item to the xcm-emulator parachain configuration of the form `AdditionalInherentCode`, which simply executes code that returns a `DispatchResult`. Whether users want to mock a storage item or run the inherent is up to them, this hook would allow them to do both. This item is optional, meaning that if it is non-set then it would do nothing --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
tmpolaczyk
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Jan 15, 2026
…mulator (paritytech#8809) With the addition of paritytech#8083 there is no possibility right now of making the xcm-executor work with custom inherents. Custom inherents are usually driven by killing a storage item of the form `wasInherentSet` `on_initialize` and asserting that such inherent was set `on_finalize`. Before the xcm-emulator worked as these hooks were running just for the ParachainSystem pallet, but now, they run for all pallets. My proposal is to add an item to the xcm-emulator parachain configuration of the form `AdditionalInherentCode`, which simply executes code that returns a `DispatchResult`. Whether users want to mock a storage item or run the inherent is up to them, this hook would allow them to do both. This item is optional, meaning that if it is non-set then it would do nothing --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues related to
xcm-emulator:PersistedValidationDataandOnSystemEventcallback.on_initializefor all pallets, not justParachainSystem.on_finalizefor all pallets, not justParachainSystem.on_idlefor all parachain pallets.