Skip to content

Cleanup unused crates #8006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serban300 merged 17 commits into from
Mar 31, 2025
Merged

Cleanup unused crates #8006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f74df07
Upgrade and use workspace dep
jasl Mar 30, 2025
00b1000
Upgrade bip39
jasl Mar 30, 2025
ab1eaa3
Use workspace deps
jasl Mar 30, 2025
abf86dd
Use workspace deps
jasl Mar 30, 2025
7a103d0
Use workspace deps
jasl Mar 30, 2025
48477ec
Use workspace deps
jasl Mar 30, 2025
2f5c7b4
Use workspace deps
jasl Mar 30, 2025
d061e2d
Use workspace deps
jasl Mar 30, 2025
ad560da
Cleanup unused deps
jasl Mar 31, 2025
33d3b7c
Use workspace deps
jasl Mar 31, 2025
45dc62c
cargo clippy --all-targets --all-features --workspace --fix
jasl Mar 31, 2025
82dca28
cargo +nightly fmt --all
jasl Mar 31, 2025
458cc80
taplo format --config .config/taplo.toml
jasl Mar 31, 2025
39ed7a5
fix ci
jasl Mar 31, 2025
cd12809
fix `cargo test --doc --workspace`
jasl Mar 31, 2025
df1231f
Update from github-actions[bot] running command 'fmt'
github-actions[bot] Mar 31, 2025
3e817cb
Merge branch 'master' into cleanup-unused-deps
jasl Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
291 changes: 3 additions & 288 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 6 additions & 10 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,8 @@ backoff = { version = "0.4" }
backtrace = { version = "0.3.71" }
binary-merkle-tree = { path = "substrate/utils/binary-merkle-tree", default-features = false }
bincode = { version = "1.3.3" }
bip39 = { version = "2.0.0" }
# personal fork here as workaround for: https://github.com/rust-bitcoin/rust-bip39/pull/64
bip39 = { package = "parity-bip39", version = "2.0.1", default-features = false }
Comment thread
serban300 marked this conversation as resolved.
bitflags = { version = "1.3.2" }
bitvec = { version = "1.0.1", default-features = false }
blake2 = { version = "0.10.4", default-features = false }
Expand Down Expand Up @@ -690,7 +691,6 @@ chain-spec-guide-runtime = { path = "docs/sdk/src/reference_docs/chain_spec_runt
chrono = { version = "0.4.31" }
cid = { version = "0.9.0" }
clap = { version = "4.5.13" }
clap-num = { version = "1.0.2" }
clap_complete = { version = "4.5.13" }
cmd_lib = { version = "1.9.5" }
coarsetime = { version = "0.1.22" }
Expand Down Expand Up @@ -803,11 +803,11 @@ frame-try-runtime = { path = "substrate/frame/try-runtime", default-features = f
fs4 = { version = "0.7.0" }
fs_extra = { version = "1.3.0" }
futures = { version = "0.3.31" }
futures-channel = { version = "0.3.23" }
futures-timer = { version = "3.0.2" }
futures-util = { version = "0.3.30", default-features = false }
generate-bags = { path = "substrate/utils/frame/generate-bags", default-features = false }
gethostname = { version = "0.2.3" }
git2 = { version = "0.20.0", default-features = false }
glob = { version = "0.3" }
glutton-westend-runtime = { path = "cumulus/parachains/runtimes/glutton/glutton-westend" }
governor = { version = "0.6.0" }
Expand Down Expand Up @@ -860,6 +860,7 @@ libc = { version = "0.2.155" }
libfuzzer-sys = { version = "0.4" }
libp2p = { version = "0.54.1" }
libp2p-identity = { version = "0.2.9" }
libp2p-kad = { version = "0.46.2", default-features = false }
libsecp256k1 = { version = "0.7.0", default-features = false }
linked-hash-map = { version = "0.5.4" }
linked_hash_set = { version = "0.1.4" }
Expand All @@ -885,7 +886,6 @@ mmr-rpc = { path = "substrate/client/merkle-mountain-range/rpc", default-feature
mockall = { version = "0.13.1" }
multiaddr = { version = "0.18.1" }
multihash = { version = "0.19.1", default-features = false }
multihash-codetable = { version = "0.1.1" }
multistream-select = { version = "0.13.0" }
names = { version = "0.14.0", default-features = false }
nix = { version = "0.29.0" }
Expand Down Expand Up @@ -1115,9 +1115,7 @@ polkavm-derive = "0.18.0"
polkavm-linker = "0.18.0"
portpicker = { version = "0.1.1" }
pretty_assertions = { version = "1.3.0" }
primitive-types = { version = "0.13.1", default-features = false, features = [
"num-traits",
] }
primitive-types = { version = "0.13.1", default-features = false, features = ["num-traits"] }
proc-macro-crate = { version = "3.0.0" }
proc-macro-warning = { version = "1.0.0", default-features = false }
proc-macro2 = { version = "1.0.86" }
Expand All @@ -1137,14 +1135,12 @@ rand_chacha = { version = "0.3.1", default-features = false }
rand_core = { version = "0.6.2" }
rand_distr = { version = "0.4.3" }
rand_pcg = { version = "0.3.1" }
rayon = { version = "1.5.1" }
rbtag = { version = "0.3" }
ref-cast = { version = "1.0.23" }
regex = { version = "1.10.2" }
relay-substrate-client = { path = "bridges/relays/client-substrate" }
relay-utils = { path = "bridges/relays/utils" }
remote-externalities = { path = "substrate/utils/frame/remote-externalities", default-features = false, package = "frame-remote-externalities" }
reqwest = { version = "0.12.9", default-features = false }
ripemd = { version = "0.1.3", default-features = false }
rlp = { version = "0.6.1", default-features = false }
rococo-emulated-chain = { path = "cumulus/parachains/integration-tests/emulated/chains/relays/rococo" }
Expand Down Expand Up @@ -1397,6 +1393,7 @@ trybuild = { version = "1.0.103" }
tt-call = { version = "1.0.8" }
tuplex = { version = "0.1", default-features = false }
twox-hash = { version = "1.6.3", default-features = false }
txtesttool = { version = "0.4.0", package = "substrate-txtesttool" }
unsigned-varint = { version = "0.7.2" }
url = { version = "2.5.4" }
void = { version = "1.0.2" }
Expand All @@ -1423,7 +1420,6 @@ xcm-procedural = { path = "polkadot/xcm/procedural", default-features = false }
xcm-runtime-apis = { path = "polkadot/xcm/xcm-runtime-apis", default-features = false }
xcm-simulator = { path = "polkadot/xcm/xcm-simulator", default-features = false }
zeroize = { version = "1.7.0", default-features = false }
zombienet-configuration = { version = "0.2.29" }
zombienet-sdk = { version = "0.2.29" }
zstd = { version = "0.12.4", default-features = false }

Expand Down
4 changes: 2 additions & 2 deletions bridges/modules/xcm-bridge-hub/src/exporter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ where
// `HaulBlobExporter` may consume the `universal_source` and `destination` arguments, so
// let's save them before
let bridge_origin_universal_location =
universal_source.clone().take().ok_or(SendError::MissingArgument)?;
universal_source.clone().ok_or(SendError::MissingArgument)?;
// Note: watch out this is `ExportMessage::destination`, which is relative to the `network`,
// which means it does not contain `GlobalConsensus`, We need to find `BridgeId` with
// `Self::bridge_locations` which requires **universal** location for destination.
let bridge_destination_universal_location = {
let dest = destination.clone().take().ok_or(SendError::MissingArgument)?;
let dest = destination.clone().ok_or(SendError::MissingArgument)?;
match dest.global_consensus() {
Ok(dest_network) => {
log::trace!(
Expand Down
1 change: 0 additions & 1 deletion bridges/relays/equivocation/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ async-std = { features = ["attributes"], workspace = true }
async-trait = { workspace = true }
bp-header-chain = { workspace = true, default-features = true }
finality-relay = { workspace = true }
frame-support = { workspace = true, default-features = true }
futures = { workspace = true }
log = { workspace = true }
num-traits = { workspace = true, default-features = true }
Expand Down
1 change: 0 additions & 1 deletion bridges/relays/lib-substrate-relay/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,5 @@ sp-runtime = { workspace = true, default-features = true }
sp-trie = { workspace = true }

[dev-dependencies]
pallet-transaction-payment = { workspace = true, default-features = true }
relay-substrate-client = { features = ["test-helpers"], workspace = true }
scale-info = { features = ["derive"], workspace = true }
1 change: 0 additions & 1 deletion bridges/relays/parachains/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@ bp-polkadot-core = { workspace = true, default-features = true }
relay-substrate-client = { workspace = true }

[dev-dependencies]
codec = { workspace = true, default-features = true }
relay-substrate-client = { features = ["test-helpers"], workspace = true }
sp-core = { workspace = true, default-features = true }
2 changes: 0 additions & 2 deletions bridges/snowbridge/pallets/system-frontend/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ xcm = { workspace = true }
xcm-executor = { workspace = true }

[dev-dependencies]
hex = { workspace = true, default-features = true }
hex-literal = { workspace = true, default-features = true }
pallet-balances = { workspace = true, default-features = true }
snowbridge-test-utils = { workspace = true }

Expand Down
1 change: 0 additions & 1 deletion bridges/snowbridge/pallets/system-v2/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ snowbridge-outbound-queue-primitives = { workspace = true }
snowbridge-pallet-system = { workspace = true }

[dev-dependencies]
hex = { workspace = true, default-features = true }
hex-literal = { workspace = true, default-features = true }
pallet-balances = { workspace = true, default-features = true }
polkadot-primitives = { workspace = true, default-features = true }
Expand Down
3 changes: 0 additions & 3 deletions bridges/snowbridge/primitives/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ xcm-executor = { workspace = true }

bp-relayers = { workspace = true }

[dev-dependencies]
hex = { workspace = true, default-features = true }

[features]
default = ["std"]
std = [
Expand Down
4 changes: 0 additions & 4 deletions bridges/snowbridge/primitives/ethereum/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ sp-std = { workspace = true }

ethabi = { workspace = true }

[dev-dependencies]
rand = { workspace = true, default-features = true }
serde_json = { workspace = true, default-features = true }

[features]
default = ["std"]
expensive_tests = []
Expand Down
4 changes: 0 additions & 4 deletions bridges/snowbridge/primitives/inbound-queue/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,15 @@ snowbridge-beacon-primitives = { workspace = true }
snowbridge-core = { workspace = true }
snowbridge-verification-primitives = { workspace = true }

hex = { workspace = true, default-features = false }
hex-literal = { workspace = true, default-features = true }

[dev-dependencies]

[features]
default = ["std"]
std = [
"alloy-core/std",
"codec/std",
"frame-support/std",
"frame-system/std",
"hex/std",
"log/std",
"scale-info/std",
"snowbridge-beacon-primitives/std",
Expand Down
4 changes: 0 additions & 4 deletions bridges/snowbridge/primitives/outbound-queue/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ ethabi = { workspace = true }
snowbridge-core = { workspace = true }
snowbridge-verification-primitives = { workspace = true }


[dev-dependencies]
hex = { workspace = true, default-features = true }

[features]
default = ["std"]
std = [
Expand Down
2 changes: 1 addition & 1 deletion bridges/snowbridge/primitives/outbound-queue/src/v1/converter/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ where
}

// Cloning destination to avoid modifying the value so subsequent exporters can use it.
let dest = destination.clone().take().ok_or(SendError::MissingArgument)?;
let dest = destination.clone().ok_or(SendError::MissingArgument)?;
if dest != Here {
log::trace!(target: "xcm::ethereum_blob_exporter", "skipped due to unmatched remote destination {dest:?}.");
return Err(SendError::NotApplicable)
Expand Down
2 changes: 0 additions & 2 deletions cumulus/client/network/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,8 @@ cumulus-relay-chain-interface = { workspace = true, default-features = true }
[dev-dependencies]
rstest = { workspace = true }
tokio = { features = ["macros"], workspace = true, default-features = true }
url = { workspace = true }

# Substrate
sc-cli = { workspace = true, default-features = true }
sc-client-api = { workspace = true, default-features = true }
sp-consensus = { workspace = true, default-features = true }
sp-core = { workspace = true, default-features = true }
Expand Down
2 changes: 0 additions & 2 deletions cumulus/client/parachain-inherent/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,11 @@ tracing = { workspace = true, default-features = true }

# Substrate
sc-client-api = { workspace = true, default-features = true }
sp-api = { workspace = true, default-features = true }
sp-crypto-hashing = { workspace = true, default-features = true }
sp-inherents = { workspace = true, default-features = true }
sp-runtime = { workspace = true, default-features = true }
sp-state-machine = { workspace = true, default-features = true }
sp-storage = { workspace = true, default-features = true }
sp-trie = { workspace = true, default-features = true }

# Cumulus
cumulus-primitives-core = { workspace = true, default-features = true }
Expand Down
4 changes: 1 addition & 3 deletions cumulus/client/pov-recovery/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,14 @@ cumulus-relay-chain-interface = { workspace = true, default-features = true }

[dev-dependencies]
assert_matches = { workspace = true }
cumulus-test-client = { workspace = true }
rstest = { workspace = true }
sc-utils = { workspace = true, default-features = true }
sp-blockchain = { workspace = true, default-features = true }
sp-tracing = { workspace = true, default-features = true }
tokio = { features = ["macros"], workspace = true, default-features = true }

# Cumulus
cumulus-test-service = { workspace = true }
cumulus-test-client = { workspace = true }

# Substrate
sc-cli = { workspace = true, default-features = true }
sc-client-api = { workspace = true, default-features = true }
1 change: 0 additions & 1 deletion cumulus/client/relay-chain-minimal-node/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ sp-blockchain = { workspace = true, default-features = true }
sp-consensus = { workspace = true, default-features = true }
sp-consensus-babe = { workspace = true, default-features = true }
sp-runtime = { workspace = true, default-features = true }
tokio = { features = ["macros"], workspace = true, default-features = true }

# cumulus deps
cumulus-primitives-core = { workspace = true, default-features = true }
Expand Down
1 change: 0 additions & 1 deletion cumulus/client/relay-chain-rpc-interface/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ prometheus-endpoint = { workspace = true, default-features = true }
sc-client-api = { workspace = true, default-features = true }
sc-rpc-api = { workspace = true, default-features = true }
sc-service = { workspace = true, default-features = true }
sp-api = { workspace = true, default-features = true }
sp-authority-discovery = { workspace = true, default-features = true }
sp-consensus-babe = { workspace = true, default-features = true }
sp-core = { workspace = true, default-features = true }
Expand Down
1 change: 0 additions & 1 deletion cumulus/client/service/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ workspace = true

[dependencies]
futures = { workspace = true }
futures-timer = { workspace = true }

# Substrate
sc-client-api = { workspace = true, default-features = true }
Expand Down
1 change: 0 additions & 1 deletion cumulus/pallets/collator-selection/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ frame-benchmarking = { optional = true, workspace = true }
pallet-aura = { workspace = true, default-features = true }
pallet-timestamp = { workspace = true, default-features = true }
sp-consensus-aura = { workspace = true, default-features = true }
sp-core = { workspace = true, default-features = true }
sp-io = { workspace = true, default-features = true }
sp-runtime = { workspace = true, default-features = true }
sp-tracing = { workspace = true, default-features = true }
Expand Down
1 change: 0 additions & 1 deletion cumulus/pallets/xcmp-queue/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ frame-benchmarking = { optional = true, workspace = true }
bp-xcm-bridge-hub-router = { optional = true, workspace = true }

[dev-dependencies]

# Substrate
frame-support = { features = ["experimental"], workspace = true, default-features = true }
pallet-balances = { workspace = true, default-features = true }
Expand Down
3 changes: 0 additions & 3 deletions cumulus/parachains/common/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,6 @@ parachain-info = { workspace = true }
pallet-authorship = { workspace = true }
sp-io = { workspace = true }

[build-dependencies]
substrate-wasm-builder = { workspace = true, default-features = true }

[features]
default = ["std"]
std = [
Expand Down
1 change: 0 additions & 1 deletion ...arachains/integration-tests/emulated/chains/parachains/assets/asset-hub-rococo/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ workspace = true

# Substrate
frame-support = { workspace = true }
pallet-asset-rewards = { workspace = true }
sp-core = { workspace = true }
sp-keyring = { workspace = true }

Expand Down
1 change: 0 additions & 1 deletion ...chains/integration-tests/emulated/chains/parachains/bridges/bridge-hub-westend/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ xcm = { workspace = true }

# Bridge dependencies
bp-messages = { workspace = true }
pallet-bridge-relayers = { workspace = true }

# Cumulus
bridge-hub-common = { workspace = true }
Expand Down
2 changes: 0 additions & 2 deletions cumulus/parachains/integration-tests/emulated/chains/relays/westend/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ sp-runtime = { workspace = true }
polkadot-primitives = { workspace = true }
westend-runtime = { workspace = true }
westend-runtime-constants = { workspace = true }
xcm = { workspace = true }
xcm-runtime-apis = { workspace = true }

# Cumulus
emulated-integration-tests-common = { workspace = true }
Expand Down
5 changes: 0 additions & 5 deletions cumulus/parachains/integration-tests/emulated/tests/assets/asset-hub-westend/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,12 @@ assert_matches = { workspace = true }
codec = { workspace = true }

# Substrate
frame-metadata-hash-extension = { workspace = true, default-features = true }
frame-support = { workspace = true }
frame-system = { workspace = true }
pallet-asset-conversion = { workspace = true }
pallet-asset-rewards = { workspace = true }
pallet-asset-tx-payment = { workspace = true }
pallet-assets = { workspace = true }
pallet-balances = { workspace = true }
pallet-message-queue = { workspace = true }
pallet-transaction-payment = { workspace = true }
pallet-treasury = { workspace = true }
sp-core = { workspace = true }
sp-runtime = { workspace = true }
Expand All @@ -39,7 +35,6 @@ xcm-runtime-apis = { workspace = true }

# Cumulus
asset-test-utils = { workspace = true, default-features = true }
assets-common = { workspace = true }
cumulus-pallet-parachain-system = { workspace = true }
cumulus-pallet-xcmp-queue = { workspace = true }
emulated-integration-tests-common = { workspace = true }
Expand Down
1 change: 0 additions & 1 deletion cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ testnet-parachains-constants = { features = [
], workspace = true, default-features = true }

# Snowbridge
snowbridge-core = { workspace = true }
snowbridge-inbound-queue-primitives = { workspace = true }
snowbridge-outbound-queue-primitives = { workspace = true }
snowbridge-pallet-inbound-queue-fixtures = { workspace = true, default-features = true }
Expand Down
2 changes: 0 additions & 2 deletions cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ workspace = true
codec = { workspace = true }
hex = { workspace = true, default-features = true }
hex-literal = { workspace = true, default-features = true }
log = { workspace = true }
scale-info = { workspace = true }

# Substrate
Expand Down Expand Up @@ -63,4 +62,3 @@ snowbridge-pallet-inbound-queue-v2 = { workspace = true }
snowbridge-pallet-outbound-queue = { workspace = true }
snowbridge-pallet-outbound-queue-v2 = { workspace = true }
snowbridge-pallet-system = { workspace = true }
snowbridge-pallet-system-v2 = { workspace = true }
4 changes: 0 additions & 4 deletions ...us/parachains/integration-tests/emulated/tests/collectives/collectives-westend/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,10 @@ publish = false
workspace = true

[dependencies]
assert_matches = { workspace = true }
codec = { workspace = true }

# Substrate
frame-support = { workspace = true }
pallet-asset-rate = { workspace = true }
pallet-assets = { workspace = true }
pallet-balances = { workspace = true }
pallet-message-queue = { workspace = true }
Expand All @@ -36,6 +34,4 @@ xcm-executor = { workspace = true }
cumulus-pallet-parachain-system = { workspace = true }
cumulus-pallet-xcmp-queue = { workspace = true }
emulated-integration-tests-common = { workspace = true }
parachains-common = { workspace = true, default-features = true }
testnet-parachains-constants = { features = ["westend"], workspace = true, default-features = true }
westend-system-emulated-network = { workspace = true }
Loading
Loading