Skip to content

[stable2412] Backport #7843#7968

Merged
EgorPopelyaev merged 6 commits intostable2412from
backport-7843-to-stable2412
Mar 20, 2025
Merged

[stable2412] Backport #7843#7968
EgorPopelyaev merged 6 commits intostable2412from
backport-7843-to-stable2412

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

Backport #7843 into stable2412 from raymondkfcheung.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Copy Markdown
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7843-to-stable2412
git worktree add --checkout .worktree/backport-7843-to-stable2412 backport-7843-to-stable2412
cd .worktree/backport-7843-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 21927dd4a5384c7cbb09c8ad0ceac483be787dd1
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Mar 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@raymondkfcheung raymondkfcheung marked this pull request as ready for review March 19, 2025 14:36
@raymondkfcheung raymondkfcheung requested a review from a team as a code owner March 19, 2025 14:36
Copy link
Copy Markdown
Contributor

@serban300 serban300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as #7966 (review)

@raymondkfcheung
Copy link
Copy Markdown
Contributor

Deleted

@raymondkfcheung raymondkfcheung enabled auto-merge (squash) March 19, 2025 15:01
@serban300
Copy link
Copy Markdown
Contributor

This doesn't look right either. Seems like the file existed before. Maybe only part of it had to be deleted ?

@raymondkfcheung
Copy link
Copy Markdown
Contributor

reverted

@EgorPopelyaev EgorPopelyaev merged commit 7f1c3d5 into stable2412 Mar 20, 2025
143 of 198 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

Status: Done
Status: To be released (SDK)

Development

Successfully merging this pull request may close these issues.

3 participants