Skip to content

Stabilize pallet view functions#7960

Merged
re-gius merged 10 commits intomasterfrom
re-gius/stabilize-view-functions
Apr 17, 2025
Merged

Stabilize pallet view functions#7960
re-gius merged 10 commits intomasterfrom
re-gius/stabilize-view-functions

Conversation

@re-gius
Copy link
Copy Markdown
Contributor

@re-gius re-gius commented Mar 18, 2025

Pallet view functions are no longer marked as experimental, and their use is suggested starting from this PR.

Your feedback is more than welcome.

See docs for a quick introduction. For more context, you can look at:

@re-gius re-gius added T1-FRAME This PR/Issue is related to core FRAME, the framework. T4-runtime_API This PR/Issue is related to runtime APIs. labels Mar 18, 2025
@re-gius re-gius requested a review from a team as a code owner March 18, 2025 17:12
@re-gius
Copy link
Copy Markdown
Contributor Author

re-gius commented Mar 20, 2025

/cmd prdoc --audience runtime_dev --bump patch

Copy link
Copy Markdown
Contributor

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@jsdw jsdw mentioned this pull request Apr 2, 2025
@Polkadot-Forum
Copy link
Copy Markdown

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/stabilizing-v16-metadata/12352/1

Copy link
Copy Markdown
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🙏

@re-gius
Copy link
Copy Markdown
Contributor Author

re-gius commented Apr 7, 2025

I'm going to merge this PR in 2 days. If someone has a pending review or wants to say anything about it, please reply before Wednesday.

@re-gius re-gius enabled auto-merge April 11, 2025 06:10
@re-gius re-gius disabled auto-merge April 11, 2025 09:39
@paritytech-workflow-stopper
Copy link
Copy Markdown

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/14438926923
Failed job name: check-runtime-migration

@re-gius re-gius added this pull request to the merge queue Apr 17, 2025
Merged via the queue into master with commit 431e068 Apr 17, 2025
235 of 244 checks passed
@re-gius re-gius deleted the re-gius/stabilize-view-functions branch April 17, 2025 10:24
Krayt78 pushed a commit to Krayt78/polkadot-sdk that referenced this pull request Apr 18, 2025
Pallet view functions are no longer marked as experimental, and their
use is suggested starting from this PR.

Your feedback is more than welcome.

See
[docs](https://paritytech.github.io/polkadot-sdk/master/frame_support/pallet_macros/attr.view_functions_experimental.html)
for a quick introduction. For more context, you can look at:

- paritytech#4722 
- paritytech#7412 
- paritytech#7830 : discussion on possible changes to pallet view functions

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
castillax pushed a commit that referenced this pull request May 12, 2025
Pallet view functions are no longer marked as experimental, and their
use is suggested starting from this PR.

Your feedback is more than welcome.

See
[docs](https://paritytech.github.io/polkadot-sdk/master/frame_support/pallet_macros/attr.view_functions_experimental.html)
for a quick introduction. For more context, you can look at:

- #4722 
- #7412 
- #7830 : discussion on possible changes to pallet view functions

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T1-FRAME This PR/Issue is related to core FRAME, the framework. T4-runtime_API This PR/Issue is related to runtime APIs.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

9 participants