Add deposit for setting session keys#7953
Merged
kianenigma merged 71 commits intoparitytech:masterfrom Jun 14, 2025
Merged
Conversation
…pallet. Update KeyDeposit type to use BalanceOf. Add tests for setting and purging keys to verify fund reservation and unreservation.
…undant storage reads and improve efficiency in the session pallet.
xlc
reviewed
Mar 18, 2025
Contributor
xlc
left a comment
xlc
left a comment
There was a problem hiding this comment.
we really need to deprecate unnamed reserves. should use names reserve instead
Contributor
Author
i wil l change to use named reserve instead then, but from what i can see i still need to use ReservableCurrency for the can_reserve function since NamedReservableCurrency doesnt seem to implement it |
bkchr
reviewed
Mar 18, 2025
…functionality for key management. Update related types and events to reflect changes from reservation to holding of funds.
kianenigma
reviewed
Apr 22, 2025
kianenigma
reviewed
Apr 22, 2025
kianenigma
reviewed
Apr 22, 2025
kianenigma
reviewed
Apr 22, 2025
Krayt78
commented
Jun 11, 2025
Krayt78
commented
Jun 11, 2025
Krayt78
commented
Jun 11, 2025
Krayt78
commented
Jun 11, 2025
Contributor
Author
|
@kianenigma its good besides CI complaining that PRdoc should be Major instead of Patch |
Contributor
|
/tip medium |
|
@kianenigma Could not submit tip :( The team has been notified. Alternatively open an issue here. |
Merged
via the queue into
paritytech:master
with commit Jun 14, 2025
4a40095
243 of 244 checks passed
Contributor
Author
|
@kianenigma maybe try the tip again, i removed the address from the description since i already have it in my bio. (might be conflicting) |
Contributor
|
/tip medium |
|
The referendum has appeared on Polkassembly. |
4 tasks
fellowship-merge-bot bot
pushed a commit
to polkadot-fellows/runtimes
that referenced
this pull request
Aug 15, 2025
This brings in `unstable2507` Polkadot SDK, and integrates new features. Integrated breaking changes to be verified by the original authors: - [ ] paritytech/polkadot-sdk#7953 @kianenigma @Ank4n acatangiu#13 - [x] paritytech/polkadot-sdk#8684 @nkpar - [x] paritytech/polkadot-sdk#8693 @tiagobndr @franciscoaguirre - [x] paritytech/polkadot-sdk#9137 @franciscoaguirre fixes #837 --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: kianenigma <kian@parity.io> Co-authored-by: Christian Langenbacher <clangenb+gh@protonmail.ch>
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
# Description closes #1625 Implement hold balance tracking for test accounts in the session pallet. Requires `pallet_session::Config` to specify: * `type Currency`, assigned to an instance of `pallet_balances`. * `type RuntimeHoldReason`, almost always set to `RuntimeHoldReason`. * `type KeyDeposit`, the amount of deposit. Set to `()` to assert no deposit amount is needed. Polkadot address: 14AgwoPjcRiEEJgjfHmvAqkjdERCG26WEvQUoGLuBzcXKMS2 --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: kianenigma <kian@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
khssnv
added a commit
to QuantumFusion-network/qf-solochain
that referenced
this pull request
Dec 9, 2025
Breaking change, paritytech/polkadot-sdk#7953.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #1625
Implement hold balance tracking for test accounts in the session pallet. Requires
pallet_session::Configto specify:*
type Currency, assigned to an instance ofpallet_balances.*
type RuntimeHoldReason, almost always set toRuntimeHoldReason.*
type KeyDeposit, the amount of deposit. Set to()to assert no deposit amount is needed.