[AHM] Revert some AH-next staking changes from master #7937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 669b889.
1 task
kianenigma
reviewed
Mar 16, 2025
| parachains_shared::migration::MigrateToV1<Runtime>, | ||
| parachains_scheduler::migration::MigrateV2ToV3<Runtime>, | ||
| pallet_staking::migrations::v16::MigrateV15ToV16<Runtime>, | ||
| pallet_staking::migrations::v17::MigrateV16ToV17<Runtime>, |
Contributor
There was a problem hiding this comment.
Unfortunately we have already upgraded westend to V17.. you can check in the chain state.
What did this migration do? We need to see if any special consideration is needed for it or not.
kianenigma
reviewed
Mar 16, 2025
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
So far looks good, but it is hard to get a picture before the last PR is also reverted.
Ank4n
reviewed
Mar 16, 2025
| let all_stakers = Ledger::<T>::iter().map(|(ctrl, l)| (ctrl, l.stash)).collect::<BTreeSet<_>>(); | ||
| let mut all_exposed = BTreeSet::new(); | ||
| ErasStakersPaged::<T>::iter().for_each(|((_era, val, _page), expo)| { | ||
| ErasStakers::<T>::iter().for_each(|(_, val, expo)| { |
Contributor
There was a problem hiding this comment.
This shouldn't be reverted.
Suggested change
| ErasStakers::<T>::iter().for_each(|(_, val, expo)| { | |
| ErasStakersPaged::<T>::iter().for_each(|((_era, val, _page), expo)| { |
Contributor
Author
|
Closed in favour of #7939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7858 (comment)
Reverts :