Skip to content

[stable2412] Backport #7446#7462

Merged
EgorPopelyaev merged 3 commits intostable2412from
backport-7446-to-stable2412
Feb 5, 2025
Merged

[stable2412] Backport #7446#7462
EgorPopelyaev merged 3 commits intostable2412from
backport-7446-to-stable2412

Conversation

@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor

Backport #7446 into stable2412 from serban300.

See the documentation on how to use this bot.

Related to #7400 and
#7417

We need this in order to be able to update `parity-scale-codec` to the
latest version after it's released. That's because `parity-scale-codec`
added support for checking for duplicate indexes at compile time.

(cherry picked from commit 37446fc)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot requested a review from a team as a code owner February 5, 2025 08:54
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Feb 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@serban300 serban300 added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Feb 5, 2025
gui1117
gui1117 previously approved these changes Feb 5, 2025
ggwpez
ggwpez previously approved these changes Feb 5, 2025
@ggwpez
Copy link
Member

ggwpez commented Feb 5, 2025

/cmd prdoc --bump none --audience runtime_dev

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@serban300
Copy link
Contributor

/cmd prdoc --bump patch --audience runtime_dev

@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 5, 2025 12:31
@EgorPopelyaev EgorPopelyaev merged commit 4f37964 into stable2412 Feb 5, 2025
125 of 145 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7446-to-stable2412 branch February 5, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch. R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants