Allow multiple transaction extension version in `UncheckedExtrinsic` type. by gui1117 · Pull Request #7035 · paritytech/polkadot-sdk

gui1117 · 2025-01-03T05:11:51Z

This PR enhance UncheckedExtrinsic type with a new optional generic: ExtensionOtherVersion.
This generic defaults to InvalidVersion meaning there is not other version than the regular version 0. This is the same behavior as before this PR.

New feature

To use this new feature, you can use the new types TxExtLineAtVers and MultiVersion to define a transaction extension with multiple version:

pub type TransactionExtensionV0 = ();
pub type TransactionExtensionV4 = ();
pub type TransactionExtensionV7 = ();

pub type OtherVersions = MultiVersion<
	TxExtLineAtVers<4, TransactionExtensionV4>;
	TxExtLineAtVers<7, TransactionExtensionV7>;
>;

pub type UncheckedExtrinsic = generic::UncheckedExtrinsic<
	AccountId,
	RuntimeCall,
	UintAuthorityId,
	TransactionExtensionV0, // The version 0, same as before
	OtherVersions, // The other versions.
>;

Breaking change

The types Preamble, CheckedExtrinsic and ExtrinsicFormat also have this new optional generic. Their type definition also have changed a bit, the General variant was 2 fields, the version and the extension, it is now only one field, the extension, and the version can be retrieve by calling extension.version()

The type inference for those types may fail because of this PR, to update the code, write some partial type: UncheckedExtrinsic<_, _, _, _>, Preamble<_, _, _>, ExtrinsicFormat<_, _> and CheckedExtrinsic<_, _, _>`.

Alternative implementation

This PR breaks the types a bit, I think it is very minimal and fine, but if this is annoying we can still keep the old types and write new types such as UncheckedExtrinsicV2, CheckedExtrinsicV2 etc..

…ension-multiple-version

bkchr

Great work!

It would be ultra nice to have some proper example. Maybe as part of the guide here in the repo. This way it would be easier to replicate the stuff.

bkchr · 2026-03-13T09:55:02Z

+	/// For the transaction extension pipeline used for the signed extrinsics it is defined as the
+	/// version 0, if defined.


This sentence is confusing.

I don't really know if this trait should specify it but the idea is that in extrinsic v4, for signed extrinsics, there no version. So to get the pipeline used you need to fetch the version 0.

I rewrote saying extrinsic v4, pipeline version 0 is used, and for extrinsic v5, for bare extrinsics pipeline version 0 is used: 1a81f0a

bkchr · 2026-03-13T10:55:41Z

+/// The generic `ExtensionOtherVersions` must not re-define a transaction extension pipeline for the
+/// version 0, it will be ignored and overwritten by `ExtensionV0`.


I don't get what you mean by this.

I tried to reword here: 22f7bcc

The thing is that if ExtensionOtherVersions also define a pipeline for the version 0 then this version is just ignored.
The version 0 is the one defined by ExtensionV0.

bkchr · 2026-03-13T11:24:42Z

+pub trait PipelineVersion {
+	/// Return the version for the given versioned transaction extension pipeline.
+	fn version(&self) -> u8;
+}


This makes sense to be its own trait, because it doesn't require the Call parameter, but PipelineWeight still makes no sense to have it separate?

I implemented here: 2abb369

The main issue is that the function extension_weight for UncheckedExtrinsic and CheckedExtrinsic and the dispatch info stuff doesn't bound the trait DispatchTransaction. But if I put the pipeline weight inside the pipeline trait, then I now need to bound the trait DispatchTransaction to access the weight on those type and in the dispatch info. Overall it is fine, it is just about adding a few bounds here and there. But this is the reason why I made it separate before.

bkchr · 2026-03-13T12:23:58Z

 	/// An old-school transaction extrinsic which includes a signature of some hard-coded crypto.
 	/// Available only on extrinsic version 4.
-	Signed(Address, Signature, Extension),
+	Signed(Address, Signature, ExtensionV0),


Yeah you are right, if we don't support this any more with version 5, it will not be important.

bkchr · 2026-03-13T12:40:31Z

+///
+/// Types of extrinsics:
+/// - **Bare**: An extrinsic without a signature or any additional data. After being checked, bare
+///   extrinsics can be applied, the apply logic is extended with `ExtensionV0`.


ExtensionV0 is only used for the deprecated unsigned transactions or?

Worth to be mentioned IMO.

It is also used for inherents. Inherents still use transaction extension like CheckWeight to register the used weight.

bkchr · 2026-03-13T12:53:59Z

+
+/// A type implements [`DecodeWithVersion`] where inner decoding is implementing
+/// [`codec::DecodeWithMemTracking`].
+pub trait DecodeWithVersionWithMemTracking: DecodeWithVersion {}


Answering myself DecodeWithMemTracking requires Decode as super trait.

Co-authored-by: Bastian Köcher <git@kchr.de>

…ension-multiple-version

gui1117 · 2026-03-16T00:54:09Z

Great work!

It would be ultra nice to have some proper example. Maybe as part of the guide here in the repo. This way it would be easier to replicate the stuff.

I will write it then, but if we merge it before it is also good and I will do in a follow-up PR.

gui1117 · 2026-03-27T07:59:35Z

Great work!
It would be ultra nice to have some proper example. Maybe as part of the guide here in the repo. This way it would be easier to replicate the stuff.

I will write it then, but if we merge it before it is also good and I will do in a follow-up PR.

I will do in a follow-up.

pgherveou

for contracts team.
all changes under Revive seems mostly mechanical, if Build / CI pass that's good for me

PR #7035 added new TypeInfo implementors, pushing rustc past its diagnostic threshold for emitting `consider using --verbose` on the TypeInfo/StorageEntryMetadataBuilder error.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

gui1117 added 27 commits December 12, 2024 20:05

WIP

b5c95b1

WIP

582cbb9

WIP

32159f9

WIP

2350e93

WIP

143b50a

cleanup

17a8dc0

WIP

a38fac3

WIP

3f657ac

Structure done: todo: renames and format

06da89b

Merge remote-tracking branch 'origin/master' into gui-transaction-ext…

b03b4eb

…ension-multiple-version

renames

cfddfa1

reorganize

3aacd46

fixes

e060cac

description draft

2c1e2fc

Merge remote-tracking branch 'origin/master' into gui-transaction-ext…

d39156e

…ension-multiple-version

refactor

0cc8f0c

doc

049ec5d

tests + fmt

d9eb5b8

multi version support 26 versions

8e32689

simplify bounds

c6aa890

refactor test

bfadf05

remove unneeded bounds

dc7944f

more tests

ad9e9ba

make invalid version safer

1812860

Merge remote-tracking branch 'origin/master' into gui-transaction-ext…

9967ab0

…ension-multiple-version

fmt

082ab90

prdoc

a4a87f5

gui1117 marked this pull request as ready for review January 8, 2025 09:44

gui1117 requested a review from a team as a code owner January 8, 2025 09:44

gui1117 added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Jan 8, 2025

bkchr approved these changes Mar 13, 2026

View reviewed changes

Update substrate/primitives/runtime/src/traits/vers_tx_ext/mod.rs

5451991

Co-authored-by: Bastian Köcher <git@kchr.de>

gui1117 requested a review from a team as a code owner March 15, 2026 22:58

gui1117 and others added 5 commits March 16, 2026 07:59

Update substrate/frame/revive/src/evm/runtime.rs

cfc4375

Co-authored-by: Bastian Köcher <git@kchr.de>

improve comments

22f7bcc

merge PipelineWeight directly into Pipeline

2abb369

Merge remote-tracking branch 'origin/master' into gui-transaction-ext…

1d822d9

…ension-multiple-version

extrinsic metadata better doc

1a81f0a

fmt + taplo

c1009cf

pgherveou added this to [preview] release tracker Mar 18, 2026

github-project-automation Bot moved this to Todo in [preview] release tracker Mar 18, 2026

pgherveou removed this from [preview] release tracker Mar 19, 2026

Merge branch 'master' into gui-transaction-extension-multiple-version

5b5f23a

pgherveou approved these changes Mar 27, 2026

View reviewed changes

gui1117 and others added 2 commits March 30, 2026 14:19

fix test: have a correct metadata ir

17c1f8f

Merge branch 'master' into gui-transaction-extension-multiple-version

5c353e4

gui1117 enabled auto-merge March 30, 2026 05:21

gui1117 added this pull request to the merge queue Mar 30, 2026

Merged via the queue into master with commit 89aa25d Mar 30, 2026
245 of 252 checks passed

gui1117 deleted the gui-transaction-extension-multiple-version branch March 30, 2026 06:55

pepoviola mentioned this pull request Mar 30, 2026

zombienet test fails after #7035 #11568

Closed

sigurpol mentioned this pull request Mar 31, 2026

Fix test-frame-ui: update .stderr snapshots after #7035 #11570

Merged

pepoviola mentioned this pull request Mar 31, 2026

[DNM] Revert "Allow multiple transaction extension version in UncheckedExtrinsic type." #11571

Closed

ggwpez added a commit to polkadot-fellows/runtimes that referenced this pull request May 4, 2026

Integrate paritytech/polkadot-sdk#7035

d05264e

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez mentioned this pull request May 4, 2026

Integrate SDK 2604 polkadot-fellows/runtimes#1159

Merged

13 tasks

		/// For the transaction extension pipeline used for the signed extrinsics it is defined as the
		/// version 0, if defined.

		/// The generic `ExtensionOtherVersions` must not re-define a transaction extension pipeline for the
		/// version 0, it will be ignored and overwritten by `ExtensionV0`.

Conversation

gui1117 commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New feature

Breaking change

Alternative implementation

Uh oh!

bkchr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gui1117 Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gui1117 commented Mar 16, 2026

Uh oh!

gui1117 commented Mar 27, 2026

Uh oh!

pgherveou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gui1117 commented Jan 3, 2025 •

edited

Loading

gui1117 Mar 16, 2026 •

edited

Loading