Bridges - revert-back congestion mechanism #6781

bkontur · 2024-12-07T00:42:37Z

Closes: #5551

Description

With permissionless lanes PR#4949, the congestion mechanism based on sending Transact(report_bridge_status(is_congested)) from pallet-xcm-bridge-hub to pallet-xcm-bridge-hub-router was replaced with a congestion mechanism that relied on monitoring XCMP queues. However, this approach could cause issues, such as suspending the entire XCMP queue instead of isolating the affected bridge. This PR reverts back to using report_bridge_status as before.

TODO

benchmarks
prdoc

Follow-up

#6231

bkontur · 2024-12-07T01:01:11Z

/cmd fmt

github-actions · 2024-12-07T01:02:57Z

Command "fmt" has started 🚀 See logs here

github-actions · 2024-12-07T01:03:23Z

Command "fmt" has finished ✅ See logs here

bkontur · 2024-12-07T20:40:24Z

bot bench cumulus-assets --runtime=asset-hub-westend --pallet=pallet_xcm_bridge_hub_router
bot bench cumulus-assets --runtime=asset-hub-rococo --pallet=pallet_xcm_bridge_hub_router

bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_xcm_bridge_hub
bot bench cumulus-bridge-hubs --runtime=bridge-hub-westend --pallet=pallet_xcm_bridge_hub

command-bot · 2024-12-07T20:40:30Z

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7875763 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 10-385f527c-4c4d-48ad-a96d-b8c29f3e2965 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-12-07T20:40:34Z

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7875764 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 11-43b17d25-8e95-4b20-b28a-7f5c33eb2fce to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-12-07T20:40:38Z

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7875765 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_xcm_bridge_hub. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 12-e6e3813b-0f45-484f-bf55-2f506dabdd4d to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-12-07T20:40:43Z

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7875766 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_xcm_bridge_hub. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-0d7458f7-3bd0-4e26-a52a-ba31fbdc45e1 to cancel this command or bot cancel to cancel all commands in this pull request.

bkontur · 2024-12-07T20:42:28Z

/cmd prdoc --audience runtime_dev --bump patch

…ump patch'

prdoc/pr_6781.prdoc

command-bot · 2024-12-07T21:00:37Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7875764 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7875764/artifacts/download.

command-bot · 2024-12-07T21:01:02Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7875763 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7875763/artifacts/download.

command-bot · 2024-12-07T21:01:10Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_xcm_bridge_hub has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7875766 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7875766/artifacts/download.

command-bot · 2024-12-07T21:01:51Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_xcm_bridge_hub has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7875765 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7875765/artifacts/download.

paritytech-workflow-stopper · 2024-12-07T21:02:25Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12215986550
Failed job name: build-rustdoc

bkontur · 2024-12-07T21:38:00Z

bot bench cumulus-assets --runtime=asset-hub-westend --pallet=pallet_xcm_bridge_hub_router
bot bench cumulus-assets --runtime=asset-hub-rococo --pallet=pallet_xcm_bridge_hub_router

bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_xcm_bridge_hub
bot bench cumulus-bridge-hubs --runtime=bridge-hub-westend --pallet=pallet_xcm_bridge_hub

command-bot · 2024-12-07T21:38:06Z

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7876021 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 14-d485bcf0-4442-405c-bdd8-0f51f1ce74bb to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-12-07T21:38:10Z

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7876022 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 15-6f5d75c3-c427-4ec5-9158-8bc46ca47c45 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-12-07T21:38:14Z

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7876023 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_xcm_bridge_hub. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 16-fa2df385-dd53-4889-aa21-3d2b7c1e117f to cancel this command or bot cancel to cancel all commands in this pull request.

…congestion

bridges/modules/xcm-bridge-hub-router/src/lib.rs

Co-authored-by: Adrian Catangiu <[email protected]>

paritytech-cmd-bot-polkadot-sdk · 2024-12-10T06:36:18Z

Created backport PR for stable2407:

[stable2407] Backport #6781 #6822 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6781-to-stable2407
git worktree add --checkout .worktree/backport-6781-to-stable2407 backport-6781-to-stable2407
cd .worktree/backport-6781-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 8f4b99cffabbe9edaa9c29f451e45cfdb4674adc
git push --force-with-lease

paritytech-cmd-bot-polkadot-sdk · 2024-12-10T06:36:25Z

Created backport PR for stable2409:

[stable2409] Backport #6781 #6823 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6781-to-stable2409
git worktree add --checkout .worktree/backport-6781-to-stable2409 backport-6781-to-stable2409
cd .worktree/backport-6781-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 8f4b99cffabbe9edaa9c29f451e45cfdb4674adc
git push --force-with-lease

paritytech-cmd-bot-polkadot-sdk · 2024-12-10T06:36:31Z

Created backport PR for stable2412:

[stable2412] Backport #6781 #6824 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6781-to-stable2412
git worktree add --checkout .worktree/backport-6781-to-stable2412 backport-6781-to-stable2412
cd .worktree/backport-6781-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 8f4b99cffabbe9edaa9c29f451e45cfdb4674adc
git push --force-with-lease

Closes: #5551 ## Description With [permissionless lanes PR#4949](#4949), the congestion mechanism based on sending `Transact(report_bridge_status(is_congested))` from `pallet-xcm-bridge-hub` to `pallet-xcm-bridge-hub-router` was replaced with a congestion mechanism that relied on monitoring XCMP queues. However, this approach could cause issues, such as suspending the entire XCMP queue instead of isolating the affected bridge. This PR reverts back to using `report_bridge_status` as before. ## TODO - [x] benchmarks - [x] prdoc ## Follow-up #6231 --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Adrian Catangiu <[email protected]> (cherry picked from commit 8f4b99c) # Conflicts: # Cargo.lock # cumulus/parachains/runtimes/assets/asset-hub-rococo/tests/tests.rs # cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs

Backport #6781 into `stable2412` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot.  --------- Co-authored-by: Branislav Kontur <[email protected]>

Backport #6781 into `stable2409` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot.  --------- Co-authored-by: Branislav Kontur <[email protected]>

Closes: #5551 ## Description With [permissionless lanes PR#4949](#4949), the congestion mechanism based on sending `Transact(report_bridge_status(is_congested))` from `pallet-xcm-bridge-hub` to `pallet-xcm-bridge-hub-router` was replaced with a congestion mechanism that relied on monitoring XCMP queues. However, this approach could cause issues, such as suspending the entire XCMP queue instead of isolating the affected bridge. This PR reverts back to using `report_bridge_status` as before. ## TODO - [x] benchmarks - [x] prdoc ## Follow-up #6231 --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Adrian Catangiu <[email protected]>

bkontur added 3 commits December 7, 2024 01:29

Revert report_bridge_status back to the router + more tests

ee1a186

Revert report_bridge_status back to the AssetHubs

cf1f232

Revert report_bridge_status back to the BridgeHubs

351fa9a

bkontur added the T15-bridges This PR/Issue is related to bridges. label Dec 7, 2024

paritytech-review-bot bot requested a review from a team December 7, 2024 00:43

Update from bkontur running command 'fmt'

c889bd6

Update from bkontur running command 'prdoc --audience runtime_dev --b…

ce504c0

…ump patch'

bkontur commented Dec 7, 2024

View reviewed changes

prdoc/pr_6781.prdoc Outdated Show resolved Hide resolved

Update prdoc/pr_6781.prdoc

cbc07d9

bkontur commented Dec 7, 2024

View reviewed changes

prdoc/pr_6781.prdoc Outdated Show resolved Hide resolved

Update prdoc/pr_6781.prdoc

ad92d1d

Fix benchmarks

c14a350

bkontur added 2 commits December 8, 2024 00:17

zepter

e0f1644

taplo

de43184

bkontur self-assigned this Dec 8, 2024

bkontur added 2 commits December 9, 2024 09:02

prdoc

6c225b0

Merge remote-tracking branch 'origin/master' into bko-bridges-revert-…

9c6a567

…congestion

bkontur added the A4-needs-backport Pull request must be backported to all maintained releases. label Dec 9, 2024

acatangiu approved these changes Dec 9, 2024

View reviewed changes

bridges/modules/xcm-bridge-hub-router/src/lib.rs Show resolved Hide resolved

bridges/modules/xcm-bridge-hub-router/src/lib.rs Show resolved Hide resolved

bkontur and others added 2 commits December 9, 2024 11:23

Update bridges/modules/xcm-bridge-hub-router/src/lib.rs

0aec959

Co-authored-by: Adrian Catangiu <[email protected]>

Update bridges/modules/xcm-bridge-hub-router/src/lib.rs

a2c0247

Co-authored-by: Adrian Catangiu <[email protected]>

franciscoaguirre approved these changes Dec 9, 2024

View reviewed changes

bkontur enabled auto-merge December 9, 2024 11:34

x3c41a approved these changes Dec 9, 2024

View reviewed changes

bkontur added 3 commits December 9, 2024 15:38

Merge branch 'master' into bko-bridges-revert-congestion

7f86f56

Merge branch 'master' into bko-bridges-revert-congestion

0b36687

Merge branch 'master' into bko-bridges-revert-congestion

90ef26b

bkontur added this pull request to the merge queue Dec 10, 2024

Merged via the queue into master with commit 8f4b99c Dec 10, 2024
196 of 199 checks passed

bkontur deleted the bko-bridges-revert-congestion branch December 10, 2024 06:35

This was referenced Dec 10, 2024

[stable2407] Backport #6781 #6822

Closed

[stable2409] Backport #6781 #6823

Merged

paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Dec 10, 2024

[stable2412] Backport #6781 #6824

Merged

bkontur mentioned this pull request Dec 23, 2024

Bridges patch applied for stable2409 polkadot-fellows/runtimes#519

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bridges - revert-back congestion mechanism #6781

Bridges - revert-back congestion mechanism #6781

bkontur commented Dec 7, 2024 •

edited

Loading

bkontur commented Dec 7, 2024

github-actions bot commented Dec 7, 2024

github-actions bot commented Dec 7, 2024

bkontur commented Dec 7, 2024

command-bot bot commented Dec 7, 2024 •

edited

Loading

command-bot bot commented Dec 7, 2024 •

edited

Loading

command-bot bot commented Dec 7, 2024 •

edited

Loading

command-bot bot commented Dec 7, 2024 •

edited

Loading

bkontur commented Dec 7, 2024

command-bot bot commented Dec 7, 2024

command-bot bot commented Dec 7, 2024

command-bot bot commented Dec 7, 2024

command-bot bot commented Dec 7, 2024

paritytech-workflow-stopper bot commented Dec 7, 2024

bkontur commented Dec 7, 2024

command-bot bot commented Dec 7, 2024 •

edited

Loading

command-bot bot commented Dec 7, 2024 •

edited

Loading

command-bot bot commented Dec 7, 2024 •

edited

Loading

paritytech-cmd-bot-polkadot-sdk bot commented Dec 10, 2024

paritytech-cmd-bot-polkadot-sdk bot commented Dec 10, 2024

paritytech-cmd-bot-polkadot-sdk bot commented Dec 10, 2024

Bridges - revert-back congestion mechanism #6781

Bridges - revert-back congestion mechanism #6781

Conversation

bkontur commented Dec 7, 2024 • edited Loading

Description

TODO

Follow-up

bkontur commented Dec 7, 2024

github-actions bot commented Dec 7, 2024

github-actions bot commented Dec 7, 2024

bkontur commented Dec 7, 2024

command-bot bot commented Dec 7, 2024 • edited Loading

command-bot bot commented Dec 7, 2024 • edited Loading

command-bot bot commented Dec 7, 2024 • edited Loading

command-bot bot commented Dec 7, 2024 • edited Loading

bkontur commented Dec 7, 2024

command-bot bot commented Dec 7, 2024

command-bot bot commented Dec 7, 2024

command-bot bot commented Dec 7, 2024

command-bot bot commented Dec 7, 2024

paritytech-workflow-stopper bot commented Dec 7, 2024

bkontur commented Dec 7, 2024

command-bot bot commented Dec 7, 2024 • edited Loading

command-bot bot commented Dec 7, 2024 • edited Loading

command-bot bot commented Dec 7, 2024 • edited Loading

paritytech-cmd-bot-polkadot-sdk bot commented Dec 10, 2024

paritytech-cmd-bot-polkadot-sdk bot commented Dec 10, 2024

paritytech-cmd-bot-polkadot-sdk bot commented Dec 10, 2024

bkontur commented Dec 7, 2024 •

edited

Loading

command-bot bot commented Dec 7, 2024 •

edited

Loading

command-bot bot commented Dec 7, 2024 •

edited

Loading

command-bot bot commented Dec 7, 2024 •

edited

Loading

command-bot bot commented Dec 7, 2024 •

edited

Loading

command-bot bot commented Dec 7, 2024 •

edited

Loading

command-bot bot commented Dec 7, 2024 •

edited

Loading

command-bot bot commented Dec 7, 2024 •

edited

Loading