Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2407] Backport #6459 #6663

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6459 into stable2407 from franciscoaguirre.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6459-to-stable2407
git worktree add --checkout .worktree/backport-6459-to-stable2407 backport-6459-to-stable2407
cd .worktree/backport-6459-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 139691b17c66aa074d2b4ae935158d4296068f72
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Nov 26, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Dec 1, 2024
@franciscoaguirre franciscoaguirre force-pushed the backport-6459-to-stable2407 branch from e9475f2 to 9597cb1 Compare December 2, 2024 15:06
@franciscoaguirre franciscoaguirre marked this pull request as ready for review December 2, 2024 15:06
@franciscoaguirre franciscoaguirre requested a review from a team as a code owner December 2, 2024 15:06
@bkontur
Copy link
Contributor

bkontur commented Dec 3, 2024

The CI pipeline was cancelled due to failure one of the required jobs. Job name: cargo-clippy Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7854900

@franciscoaguirre clippy needs some love here

bkontur
bkontur previously approved these changes Dec 3, 2024
@franciscoaguirre franciscoaguirre requested a review from a team as a code owner December 4, 2024 11:04
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7862519

@franciscoaguirre franciscoaguirre enabled auto-merge (squash) December 4, 2024 15:45
@EgorPopelyaev EgorPopelyaev merged commit 37323c9 into stable2407 Dec 4, 2024
124 of 161 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6459-to-stable2407 branch December 4, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch. T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants