rpc: re-use server builder per rpc interface #6652
Conversation
niklasad1
added
T0-node
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
bot fmt |
|
@niklasad1 https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7820153 was started for your command Comment |
|
@niklasad1 Command |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6652-to-stable2407
git worktree add --checkout .worktree/backport-6652-to-stable2407 backport-6652-to-stable2407
cd .worktree/backport-6652-to-stable2407
git reset --hard HEAD^
git cherry-pick -x e1add3e8a8faa611e63e3f962b6c5b13ba37e449
git push --force-with-lease |
This PR changes that the server builder is created once and shared/cloned for each connection to avoid some extra overhead to construct this for each connection (as it was before). I don't know why I constructed a new builder for each connection because it's not needed but shouldn't make a big difference to my understanding. --------- Co-authored-by: command-bot <> (cherry picked from commit e1add3e)
|
Successfully created backport PR for |
This PR changes that the server builder is created once and shared/cloned for each connection to avoid some extra overhead to construct this for each connection (as it was before). I don't know why I constructed a new builder for each connection because it's not needed but shouldn't make a big difference to my understanding. --------- Co-authored-by: command-bot <> (cherry picked from commit e1add3e)
|
Successfully created backport PR for |
Backport #6652 into `stable2412` from niklasad1. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Niklas Adolfsson <[email protected]>
Backport #6652 into `stable2409` from niklasad1. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Niklas Adolfsson <[email protected]>
This PR changes that the server builder is created once and shared/cloned for each connection to avoid some extra overhead to construct this for each connection (as it was before).
I don't know why I constructed a new builder for each connection because it's not needed but shouldn't make a big difference to my understanding.