Only mess with coretime if we are registering an actual parachain.#6554
Merged
Only mess with coretime if we are registering an actual parachain.#6554
Conversation
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
eskimor
added
R0-no-crate-publish-required
s0me0ne-unkn0wn
approved these changes
Nov 20, 2024
ordian
approved these changes
Nov 20, 2024
pepoviola
approved these changes
Nov 20, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Krayt78
pushed a commit
to Krayt78/polkadot-sdk
that referenced
this pull request
Dec 18, 2024
…aritytech#6554) Co-authored-by: Robert <robert@gonimo.com> Co-authored-by: ordian <write@reusable.software>
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
…aritytech#6554) Co-authored-by: Robert <robert@gonimo.com> Co-authored-by: ordian <write@reusable.software>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
Rewrite it with zombienet-sdk, while simplyfing it. The main source of flakyness was timing, because this test was manually registering parachains, so we had to wait for 2 sessions. Waiting for session change with zndsl zombienet was a hassle, whereas with zombienet-sdk is much easier. Moreover, I needed to replicate the logic change from: #6554 to the genesis parachain registration, so that we don't automatically get an extra assigned core when registering a parachain (unless we want one)
This was referenced Jul 16, 2025
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
Rewrite it with zombienet-sdk, while simplyfing it. The main source of flakyness was timing, because this test was manually registering parachains, so we had to wait for 2 sessions. Waiting for session change with zndsl zombienet was a hassle, whereas with zombienet-sdk is much easier. Moreover, I needed to replicate the logic change from: #6554 to the genesis parachain registration, so that we don't automatically get an extra assigned core when registering a parachain (unless we want one)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.