Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/check-semver: Fix semver failed step #6535

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Nov 19, 2024

The semver-check is failing with the following error:

error[E0658]: use of unstable library feature 'error_in_core'
  --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-decode-0.5.0/src/decoding/extrinsic_decoder.rs:56:6
   |
56 | impl core::error::Error for ExtrinsicDecodeError {}
   |      ^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #103765 <https://github.com/rust-lang/rust/issues/103765> for more information
   = help: add `#![feature(error_in_core)]` to the crate attributes to enable
   = note: this compiler was built on 2024-05-31; consider upgrading it if it is out of date

This is related to the toolchain nightly version 1.80. In rust, 1.81 the core::error::Error is stable.

After updating the rust-toolchain, parity-publish crate must be updated as well.
The cargo-semver-checks dependency of parity-publish crate is updated from 0.34 to 0.38.
This update enables rustdoc v36 that fixes the following issue:

 validating prdocs...
checking file changes...
checking semver changes...
(1/18) building frame-support-HEAD...
(2/18) building frame-support-28.0.0...
Error: rustdoc format v36 for file /__w/polkadot-sdk/polkadot-sdk/target/doc/frame_support.new is not supported

This PR is pending on a release of parity-publish to version 0.9.0 (fixes already on origin/master)

@lexnv lexnv added R0-silent Changes should not be mentioned in any release notes D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Nov 19, 2024
@lexnv lexnv self-assigned this Nov 19, 2024
@lexnv lexnv requested review from a team as code owners November 19, 2024 13:26
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
Copy link
Contributor Author

lexnv commented Nov 25, 2024

@EgorPopelyaev @alvicsam @Morganamilo could you please take a look over this?

I want to unblock the semver-checks to merge the metadata V16 unstable:

Thanks 🙏

@lexnv lexnv added this pull request to the merge queue Nov 26, 2024
Merged via the queue into master with commit 8216235 Nov 26, 2024
196 of 200 checks passed
@lexnv lexnv deleted the lexnv/fix-ci-semver-check branch November 26, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants