Zero refund check for FungibleAdapter #6506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscoaguirre
approved these changes
Nov 15, 2024
franciscoaguirre
added
T2-pallets
|
/cmd prdoc |
|
@Dinonard Please edit the prdoc, bump should be patch, audience "Runtime User" |
|
Forgot about PR doc, my bad. Done now. |
shawntabrizi
approved these changes
Nov 17, 2024
davidk-pt
approved these changes
Nov 18, 2024
|
Can this be merged via the bot? |
|
@franciscoaguirre could you please merge this? |
Merged
via the queue into
paritytech:master
with commit Nov 26, 2024
f520adb
195 of 200 checks passed
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6506-to-stable2407
git worktree add --checkout .worktree/backport-6506-to-stable2407 backport-6506-to-stable2407
cd .worktree/backport-6506-to-stable2407
git reset --hard HEAD^
git cherry-pick -x f520adb0aacd51247ed548c7db9bef874c2cca9e
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6506-to-stable2409
git worktree add --checkout .worktree/backport-6506-to-stable2409 backport-6506-to-stable2409
cd .worktree/backport-6506-to-stable2409
git reset --hard HEAD^
git cherry-pick -x f520adb0aacd51247ed548c7db9bef874c2cca9e
git push --force-with-lease |
EgorPopelyaev
added a commit
that referenced
this pull request
Dec 4, 2024
Backport #6506 into `stable2407` from Dinonard. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Dino Pačandi <[email protected]> Co-authored-by: Egor_P <[email protected]>
EgorPopelyaev
added a commit
that referenced
this pull request
Dec 11, 2024
Backport #6506 into `stable2409` from Dinonard. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Dino Pačandi <[email protected]> Co-authored-by: EgorPopelyaev <[email protected]>
Krayt78
pushed a commit
to Krayt78/polkadot-sdk
that referenced
this pull request
Dec 18, 2024
`FungibleAdapter` will now check if the _refund amount_ is zero before calling deposit & emitting an event. Fixes paritytech#6469. --------- Co-authored-by: GitHub Action <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FungibleAdapterwill now check if the refund amount is zero before calling deposit & emitting an event.Fixes #6469.