Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2407] Backport #6417 #6437

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[stable2407] Backport #6417 #6437

merged 1 commit into from
Nov 12, 2024

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link

Backport #6417 into stable2407 from alindima.

See the documentation on how to use this bot.

@alindima @github-actions
fix prospective-parachains best backable chain reversion bug (#6417)
324b3f8 
Kudos to @EclesioMeloJunior for noticing it

Also added a regression test for it. The existing unit test was
exercising only the case where the full chain is reverted

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
(cherry picked from commit 05ad547)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Nov 11, 2024
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Nov 11, 2024
@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@alindima alindima requested review from eskimor and bkchr November 11, 2024 12:19
@alindima alindima enabled auto-merge (squash) November 12, 2024 07:51
@EgorPopelyaev EgorPopelyaev merged commit 0e22c93 into stable2407 Nov 12, 2024
128 of 165 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6417-to-stable2407 branch November 12, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandreim sandreim sandreim approved these changes

@eskimor eskimor eskimor approved these changes

@bkchr bkchr Awaiting requested review from bkchr

Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eskimor @sandreim @EgorPopelyaev @alindima