-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[CI] Skip SemVer on R0-silent and update docs #6285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3c1617a
Update doc and fix bot
ggwpez 5bb58a7
Skip SemVer check if R0-silent
ggwpez 9678d12
Also run on label change
ggwpez 2285948
DNM: test change
ggwpez 5d72a00
Revert "DNM: test change"
ggwpez 39998e7
Add audience fix
ggwpez fd3849a
docs
ggwpez fc6cb1a
Merge branch 'master' into oty-prdoc-fix
ggwpez 895a07e
Merge branch 'master' into oty-prdoc-fix
ggwpez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ name: Check semver | |
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened, ready_for_review] | ||
| types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled] | ||
| workflow_dispatch: | ||
| merge_group: | ||
|
|
||
|
|
@@ -62,21 +62,29 @@ jobs: | |
|
|
||
| echo "PRDOC_EXTRA_ARGS=--max-bump minor" >> $GITHUB_ENV | ||
|
|
||
| - name: Echo Skip | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you move the "comment if backport" to an extra job, you would only need to write one |
||
| if: ${{ contains(github.event.pull_request.labels.*.name, 'R0-silent') }} | ||
| run: echo "Skipping this PR because it is labeled as R0-silent." | ||
|
|
||
| - name: Rust Cache | ||
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-silent') }} | ||
| uses: Swatinem/rust-cache@82a92a6e8fbeee089604da2575dc567ae9ddeaab # v2.7.5 | ||
| with: | ||
| cache-on-failure: true | ||
|
|
||
| - name: Rust compilation prerequisites | ||
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-silent') }} | ||
| run: | | ||
| rustup default $TOOLCHAIN | ||
| rustup component add rust-src --toolchain $TOOLCHAIN | ||
|
|
||
| - name: install parity-publish | ||
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-silent') }} | ||
| # Set the target dir to cache the build. | ||
| run: CARGO_TARGET_DIR=./target/ cargo install [email protected] --locked -q | ||
|
|
||
| - name: check semver | ||
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-silent') }} | ||
| run: | | ||
| if [ -z "$PR" ]; then | ||
| echo "Skipping master/merge queue" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ on: | |
| required: true | ||
| options: | ||
| - "TODO" | ||
| - "no_change" | ||
| - "none" | ||
| - "patch" | ||
| - "minor" | ||
| - "major" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: may be worth moving the audience map into separate var in this scope, so the allowed_audiences could be formed dynamically out of aliases keys?