[Do not merge] net/discovery: Remove legacy /kad protocol#6109
Closed
[Do not merge] net/discovery: Remove legacy /kad protocol#6109
/kad protocol#6109Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
added
T0-node
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
…exnv/disable-legacy-kad
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Contributor
Contributor
Author
Yep that's a good point. Will crawl the DHTs and see if someone is still running legacy only kademlia, meanwhile will add a Do not merge on this pr |
lexnv
changed the title
/kad protocol/kad protocol
Contributor
|
This is needed for libp2p 0.54 upgrade that to not use deprecated features |
2 tasks
Contributor
Author
|
No longer needed, will reconsider in the future |
|
As context, may I ask if there's a superseding issue/PR/design decision which makes this no longer needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy
/kadkademlia protocol.Instead, nodes use the genesis based kademlia protocol for the discovery process.
Part of:
ProtocolId-based protocol names #504cc @paritytech/networking